[FEAT] 쿠폰 API 구현 - 비관적 락, 낙관적 락 #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwanse
reviewed
Sep 26, 2024
src/main/java/com/example/book_your_seat/coupon/controller/CouponController.java
Show resolved
Hide resolved
kwanse
reviewed
Sep 26, 2024
src/main/java/com/example/book_your_seat/coupon/controller/dto/CouponCreateRequest.java
Show resolved
Hide resolved
kwanse
reviewed
Sep 26, 2024
| } | ||
| ); | ||
| } | ||
| } |
kwanse
reviewed
Sep 26, 2024
src/test/java/com/example/book_your_seat/service/coupon/CouponCommandServiceImplTest.java
Outdated
Show resolved
Hide resolved
kwanse
reviewed
Sep 26, 2024
| //then | ||
| assertEquals(100, coupon.getAmount()); | ||
| assertEquals(FIVE, coupon.getDiscountRate()); | ||
| } |
There was a problem hiding this comment.
DisplayName 을 친절하게 작성해주신 것 같습니당 bb
kwanse
reviewed
Sep 26, 2024
src/test/java/com/example/book_your_seat/service/coupon/CouponQueryServiceImplTest.java
Outdated
Show resolved
Hide resolved
AnTaeho
reviewed
Sep 26, 2024
There was a problem hiding this comment.
고생하셨습니다!
@DisplayName 저도 자세하게 짤껄 반성하게 됩니다...!
테스트 케이스도 자세하게 잘 작성하신 것 같아요
Comment on lines
32
to
35
| @PostMapping | ||
| public ResponseEntity<CouponIdResponse> createCoupon(@RequestBody @Valid CouponCreateRequest couponCreateRequest) { | ||
| return ResponseEntity.status(HttpStatus.CREATED).body(couponCommandService.createCoupon(couponCreateRequest)); | ||
| } |
There was a problem hiding this comment.
P 4~5
Suggested change
| @PostMapping | |
| public ResponseEntity<CouponIdResponse> createCoupon(@RequestBody @Valid CouponCreateRequest couponCreateRequest) { | |
| return ResponseEntity.status(HttpStatus.CREATED).body(couponCommandService.createCoupon(couponCreateRequest)); | |
| } | |
| @PostMapping | |
| public ResponseEntity<CouponIdResponse> createCoupon( | |
| @RequestBody @Valid CouponCreateRequest couponCreateRequest | |
| ) { | |
| return ResponseEntity | |
| .status(HttpStatus.CREATED) | |
| .body(couponCommandService.createCoupon(couponCreateRequest)); | |
| } |
저도 이렇게 줄바꿈을 해주면 좋을 것 같습니다!
Comment on lines
39
to
41
| if(coupon.getAmount() <= 0) { | ||
| throw new IllegalArgumentException(COUPON_OUT_OF_STOCK); | ||
| } |
There was a problem hiding this comment.
P3.5
Suggested change
| if(coupon.getAmount() <= 0) { | |
| throw new IllegalArgumentException(COUPON_OUT_OF_STOCK); | |
| } | |
| if(coupon.noStock()) { | |
| throw new IllegalArgumentException(COUPON_OUT_OF_STOCK); | |
| } |
개인적으론 이렇게 coupon 객체에 재고가 없는지 물어보거나
아니면 재고를 감소 시킬때 체크해주는 것이 더 객체지향적이라고 생각합니다!
There was a problem hiding this comment.
전 여태까지 개발 헛했네요....🥹 감사합니다 태호님 짱이십니다!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
쿠폰 발급 API Controller는 따로 구현하지 않았습니다.
✅ PR 포인트 & 궁금한 점
낙관적 락의 경우 MySQL 테스트할 때 실패합니다. MySQL 자체 s-lock, x-lock 규칙 때문으로 보입니다.
자세한 내용은 노션에 적어두었습니다~
낙관적 락 이용 시 DeadLock 발생