[FEAT] Concert 조회, 삽입, 삭제 구현 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnTaeho
reviewed
Sep 24, 2024
src/main/java/com/example/book_your_seat/concert/controller/dto/AddConcertRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/book_your_seat/concert/controller/dto/ConcertResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/book_your_seat/concert/domain/Concert.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/book_your_seat/concert/domain/Concert.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Repository |
There was a problem hiding this comment.
P4
제가 알기로 JPARepository를 상속 받으면 @repository가 필요 없는 것으로 알고 있는데
리포지토리라는 것을 명시해주기 위해서 작성하신건가요?
그렇다면 저는 있어도 좋다고 생각합니다!
There was a problem hiding this comment.
제가 알기로 JPARepository를 상속 받으면 @repository가 필요 없는 것으로 알고 있는데 리포지토리라는 것을 명시해주기 위해서 작성하신건가요? 그렇다면 저는 있어도 좋다고 생각합니다!
그냥 이름표 같은 느낌으로 줘봤습니당..!
kcsc2217
reviewed
Sep 24, 2024
src/main/java/com/example/book_your_seat/concert/controller/dto/AddConcertRequest.java
Outdated
Show resolved
Hide resolved
tnals2384
requested changes
Sep 24, 2024
src/main/java/com/example/book_your_seat/concert/service/ConcertCommandServiceImpl.java
Outdated
Show resolved
Hide resolved
kimdw0823
reviewed
Sep 24, 2024
src/test/java/com/example/book_your_seat/service/ConcertServiceTest.java
Outdated
Show resolved
Hide resolved
tnals2384
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete Id 유효성 검사
Insert, Delete 시 Bulk 로 적용
-> ConcertJdbcRepository 생성
-> ConcertRepository implements JpaRepository, ConcertJdbcRepository
Concert 의 time -> startHour
ConcertCommandService.add 의 return 값이 ConcertResponse 에서 Long 으로 변경
5.ConcertController.add 의 return 값이 ConcertResponse 에서 void 로 변경
예매 가능 시간은 공연 시작날로부터 일주일 전, 낮 12시로 설정
유효성 메세지 추가
그 외 여러가지 상수값들 잔뜩 추가,,
startHour 최소, 최대 유효성 검증 추가
테스트용 Schema 추가
Concert 테스트 추가
ConcertServiceTest 에 예매 가능 시간 테스트 추가