Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kwanse
reviewed
Sep 24, 2024
|
|
||
| private String code; | ||
|
|
||
| private String message; |
AnTaeho
reviewed
Sep 24, 2024
| public ResponseEntity<ErrorResult> catchError(IllegalArgumentException e) { | ||
| log.error("[exceptionHandle] ex", e); | ||
|
|
||
| ErrorResult errorResult = new ErrorResult("BAD", e.getMessage()); |
There was a problem hiding this comment.
이 부분의 "BAD"를 HttpStatus.BAD_REQUEST.name() 으로 바꾸시면 될 것 같습니다!
tnals2384
reviewed
Sep 24, 2024
|
|
||
| import lombok.Data; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
@DaTa 어노테이션은 삭제해도 될 것 같아요! getter가 필요해도 setter는 생성하지 않는게 좋다고 생각합니다!!
kwanse
reviewed
Sep 24, 2024
|
|
||
| import lombok.Data; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
생성자에서 데이터를 입력받은 후 수정이나 조회가 필요 없어서 @DaTa 는 없어도 될 것 같습니당
AnTaeho
reviewed
Sep 24, 2024
Comment on lines
17
to
19
| public ErrorResult(String code) { | ||
| this.code = code; | ||
| } |
There was a problem hiding this comment.
Suggested change
| public ErrorResult(String code) { | |
| this.code = code; | |
| } | |
| public ErrorResult(String code) { | |
| this.code = code; | |
| this.message = "bad request"; | |
| } |
이렇게 수정하시면 record 사용가능 할 듯 합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ 피드백 반영사항
✅ PR 포인트 & 궁금한 점