Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site): empty frame name and props #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaziyarMK
Copy link
Contributor

  • creating a frame without specifying it's name bugs the editor as the frame name is used as it's ID
  • cannot remove "create frame" modal props after adding any

Copy link

vercel bot commented Jun 25, 2024

@MaziyarMK is attempting to deploy a commit to the Prev Wong's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: d9c46e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@prevwong prevwong changed the title bug fix: Fix empty frame name and props fix(site): Fix empty frame name and props Jun 28, 2024
@prevwong prevwong changed the title fix(site): Fix empty frame name and props fix(site): empty frame name and props Jun 28, 2024
@prevwong prevwong force-pushed the main branch 2 times, most recently from 7b9ed15 to a9cd8bf Compare July 5, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant