Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #77: prettier-js cleanse the code #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t1anchen
Copy link

Problem

See the issue #77

Brief Analysis

After debugging the procedure, it is found that the call-process calls prettier with arguments with outputting to temporary files before doing patching. Original implementation is to input code content to prettier via standard input, however somehow it does not work under win11/powershell. When putting the code file as argument, the reformat is working (e.g. prettier xxx.js).

Test Coverage

Only tested on Win11. Environment can be found in issue #77 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant