Allow specifying diff program #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be very useful to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems such as OpenBSD, the
diffprogram does not support some of the features available under GNU diff, e.g.--strip-trailing-cr. AFAIK, there's no way to reproduce the behavior of--strip-trailing-crwithout piping totrorsed(which is probably not ideal).So I think it might make sense to allow specifying diff program, so I can install
gdiffand configure prettier-emacs to use it. This PR basically addprettier-js-diff-commandto defcustom, and use it in place of the existingdiffstring.Thanks!