Correct Moon Ball bug documentation (#1133)

pret · Oct 17, 2024 · 0ebea8c · 0ebea8c
1 parent 1febb75
commit 0ebea8c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md
@@ -1100,10 +1100,16 @@ This can occur if your party and current PC box are both full when you start the
 
 ### Moon Ball does not boost catch rate
 
+The Moon Ball checks the wrong memory address for the wrong item ID, so no Pokémon can receive the boost.
+
 **Fix:** Edit `MoonBallMultiplier` in [engine/items/item_effects.asm](https://github.com/pret/pokecrystal/blob/master/engine/items/item_effects.asm):
 
 ```diff
 -; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
+ 	inc hl
+-	inc hl
+-	inc hl
+
  	push bc
  	ld a, BANK("Evolutions and Attacks")
  	call GetFarByte
@@ -1113,6 +1119,8 @@ This can occur if your party and current PC box are both full when you start the
  	ret nz
 ```
 
+Note that this fix only accounts for Pokémon that evolve via Moon Stone as their first evolution method. However, that is sufficient to cover all Pokémon in the game that can evolve by Moon Stone.
+
 
 ### Love Ball boosts catch rate for the wrong gender
 

diff --git a/engine/items/item_effects.asm b/engine/items/item_effects.asm
@@ -913,11 +913,11 @@ MoonBallMultiplier:
 	pop bc
 	ret nz
 
+; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
 	inc hl
 	inc hl
 	inc hl
 
-; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
 	push bc
 	ld a, BANK("Evolutions and Attacks")
 	call GetFarByte