Add gpg as a compression option #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to add public-key encryption. This is very similar to #20, however, use of public-key encryption instead of a shared password helps in certain compliance situations.
The use case is to allow any number of ZFS machines with a public key to upload backups to S3. This key can be freely shared throughout the organization without fear of compromise. When restoring, access to the private key is required.
Due to its use as a compression utility and the similar nature in which gpg is implemented to other compression utilities, it made more sense to add it as a compression option instead of extending the hard work of @kithrup in the pull request mentioned above.