Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adnuntius Bid Adapter: Refactoring code #3945

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mikael-lundin
Copy link
Contributor

Moving code out to their own files so that it's a bit easier to read.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cf1a565

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adnuntius/adnuntius.go:22:			Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adnuntius/adnuntius.go:32:			MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/adnuntius/adnuntius.go:36:			MakeBids		81.8%
github.com/prebid/prebid-server/v2/adapters/adnuntius/request_functions.go:16:		makeEndpointUrl		92.9%
github.com/prebid/prebid-server/v2/adapters/adnuntius/request_functions.go:65:		getImpSizes		90.0%
github.com/prebid/prebid-server/v2/adapters/adnuntius/request_functions.go:85:		setHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/adnuntius/request_functions.go:101:		getSiteExtAsKv		80.0%
github.com/prebid/prebid-server/v2/adapters/adnuntius/request_functions.go:111:		getGDPR			92.9%
github.com/prebid/prebid-server/v2/adapters/adnuntius/request_functions.go:139:		generateRequests	92.0%
github.com/prebid/prebid-server/v2/adapters/adnuntius/response_functions.go:16:		generateAdResponse	82.1%
github.com/prebid/prebid-server/v2/adapters/adnuntius/response_functions.go:88:		generateReturnExt	86.7%
github.com/prebid/prebid-server/v2/adapters/adnuntius/response_functions.go:122:	generateBidResponse	88.0%
total:											(statements)		89.4%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant