Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alloc overhead in hot path for keyboard checks #6368

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix alloc overhead in hot path for keyboard checks #6368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion osu.Framework/Input/Bindings/KeyCombination.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,14 @@ internal static bool IsPressed(ImmutableArray<InputKey> pressedPhysicalKeys, Inp
return pressedPhysicalKeys.Contains(candidateKey);

Debug.Assert(candidateKey.IsVirtual());
return pressedPhysicalKeys.Any(k => getVirtualKey(k) == candidateKey);

foreach (var pk in pressedPhysicalKeys)
{
if (getVirtualKey(pk) == candidateKey)
return true;
}

return false;
}

public bool Equals(KeyCombination other) => Keys.SequenceEqual(other.Keys);
Expand Down
Loading