Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement native method for PresentFileExternally in MacOS #6365

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Implement native method for PresentFileExternally in MacOS #6365

merged 4 commits into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. PresentFileExternally for macos

    @cdwcgt
    cdwcgt committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    14ec8ec View commit details
    Browse the repository at this point in the history

  2. move native method to NSWorkspace 

    Co-Authored-By: PercyDan <[email protected]>
    @cdwcgt @PercyDan54
    cdwcgt and PercyDan54 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    463ae73 View commit details
    Browse the repository at this point in the history

  3. Check file exists for PresentFileExternally 

    mac's native method will not open file if file is not exists

in this case, we fallback to `OpenFileExternally`, so that we can show the folder and without highlight

Co-Authored-By: PercyDan <[email protected]>
    @cdwcgt @PercyDan54
    cdwcgt and PercyDan54 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    11fc589 View commit details
    Browse the repository at this point in the history

  4. Fix runtime log test no longer selecting file

    @peppy
    peppy committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    63e8cd2 View commit details
    Browse the repository at this point in the history