Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vpk package with old AppImage runtime #179

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Oct 10, 2024

Closes ppy/osu#30187

It turns out that the new AppImage runtime does not play nice with an external tool called AppImageLauncher, which simply doesn't seem to support the type-2 runtime: AppImage/type2-runtime#12

Resulting in many projects experiencing the same/similar issues:

And now, osu!.

Velopack switched to type-2 upon request, because we wanted to use zstd compression. This was my mistake, because we were actually using zlib (which is mapped to by gzip). The PRs involved were:

I will be PRing the revert to Velopack upstream, but in the meantime I've built a custom package from https://github.com/smoogipoo/velopack/tree/revert-type2-runtime + https://github.com/smoogipoo/velopack/actions/runs/11274894456

@peppy I intend to rebuild the existing release on Linux ASAP to prevent more issues like ppy/osu#30187

I have tested that it runs, but I don't have AppImageLauncher installed so have not reproed the original issue.

@smoogipoo
Copy link
Contributor Author

Velopack PR: velopack/velopack#257

@peppy peppy merged commit 5ccabf6 into ppy:master Oct 10, 2024
2 checks passed
@peppy
Copy link
Member

peppy commented Oct 10, 2024

Linux and iOS are trying hard to top each other for your valuable dev time 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't launch AppImage after latest update
2 participants