Master

[danielspaniel]

Here are my refactors .. little bit here and there.

[abhilashlr]

Hey @danielspaniel, will this work for people still using < 2.0 Ember?

[danielspaniel]

yes @abhilashlr it does .. I tested on 1.11 and 1.12
make sure you pull the very latest because I fixed it ( because in first commit it did not work for < 2.0 )

[abhilashlr]

Awesome. So what's the plan? Are we going to contribute in this repo or yours? Also is your travis build succeeding? Am seeing failure cases.

[danielspaniel]

Well .. by contributing to mine you contribute to the other because with a pull request the new code can be added to the other.
Since you don't have rights to change the original code you can only do it with pull request.
Writing tests to show that index error and loading pages are not included would be pretty awesome and would help alot lot.

[danielspaniel]

Of course you can always make your own fork and work on that one and submit a pull request of your own.

[abhilashlr]

I was wondering if you were going to create a new repo from scratch and do these there. Makes sense.

[poteto]

Let me check out the test failures. Could you also rebase this against current master? It's currently unmergeable

[danielspaniel]

ok ... will try

[danielspaniel]

travis is not loving running tests with chrome:
google-chrome-stable : Depends: libstdc++6 (>= 4.8.0) but 4.6.3-1ubuntu5 is to be installed
Depends: lsb-base (>= 4.1) but 4.0-0ubuntu20.3 is to be installed

[abhilashlr]

I faced the same prob in one of my PRs
On 7 Jun 2016 6:05 am, "Daniel Sudol" [email protected] wrote:

travis in not loving running tests with chrome:
google-chrome-stable : Depends: libstdc++6 (>= 4.8.0) but 4.6.3-1ubuntu5
is to be installed
Depends: lsb-base (>= 4.1) but 4.0-0ubuntu20.3 is to be installed

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#78 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFZ7imS_rZIqlS69RKAYZJmz3gSgaRLYks5qJLzigaJpZM4IuNlV
.

[danielspaniel]

easy answer is to not build with chrome .. but use phantom 2 .. i will change that unless @poteto has a solution for this?

[abhilashlr]

OK. I will use that in my PR as well.

[homu]

☔ The latest upstream changes (presumably #91) made this pull request unmergeable. Please resolve the merge conflicts.