[WIP] Adds nodejs-axios codegen #245
Conversation
- added axios support
someshkoli
force-pushed
the
codegen/node-axios
branch
from
6fde970
to
171de96
Compare
|
hey @shreys7 , the build is failing due to timeout in java-okhttp can you check once if there's something missing ? |
|
possible duplicate, #232 |
|
Yeah, we both made pr almost at the same time without knowing each other's work. There's a closed PR #236. Had to close this as the branch was bit messed up. |
| // Compile script required to compile the code snippet | ||
| compileScript: '', | ||
| // Array of name of collections for which newman tests has to be skipped. | ||
| skipCollections: ['sameNameHeadersCollection', 'formdataCollection', 'formdataFileCollection'] |
There was a problem hiding this comment.
Why are these collections skipped?
There was a problem hiding this comment.
i don't actually remember :. ill test again maybe
|
I think URL, method, body, etc. can also be provided in the config object of Axios. Can you check it once? If possible, can you make the required changes. |
|
Yeah it can be done. Axios can be used in 2 ways and this is one of them and ig majority of people use this approach. |
|
We will look at it and take it up if the users are requesting the other approach. For now, we would like to have method, URL, body, etc. to be part of the config object @someshkoli |
|
any updates @someshkoli ? |
|
Nah the tests were still failing. Was waiting for your pr to get merged #246. |
|
I am asking about the configuration part. The body, method etc. |
|
Yeah it is |
|
Okay. As you have good enough context too, can you go through #232 and add your sanity review there? @someshkoli |
|
Sure I'll do that. |
|
Closing this, focussing on #232 |
Closes #135
Adds support for axios codegen as requested in #135
snippet samples:
post req:
get req: