Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat swap #206

Merged
merged 10 commits into from
Apr 28, 2024
Merged

Feat swap #206

merged 10 commits into from
Apr 28, 2024

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented Apr 28, 2024

Includes swap feature!

  • there could be scope for improvement on UX but it works for now!!

deployed to fly staging btw

@wtfsayo wtfsayo requested a review from plor April 28, 2024 17:19
plor
plor approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right that redeem isn't hooked up yet? Also, slightly worried about the portr address in too many places. Good to go generally though.

web-portal/frontend/pages/api/price.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty file?

@wtfsayo
Copy link
Contributor Author

wtfsayo commented Apr 28, 2024

Am I right that redeem isn't hooked up yet? Also, slightly worried about the portr address in too many places. Good to go generally though.

Yes! Only swap as of now!

@wtfsayo wtfsayo merged commit 43d9b22 into develop Apr 28, 2024
@wtfsayo wtfsayo deleted the feat-swap branch April 29, 2024 07:35
@wtfsayo wtfsayo linked an issue May 2, 2024 that may be closed by this pull request
implement swapping and redeeming UI #169
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plor plor plor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement swapping and redeeming UI
2 participants
@wtfsayo @plor