Adding GorGor species and demography

[ChristianHuber]

No description provided.

[petrelharp]

This looks great, @ChristianHuber - but we're hitting a bigger issue we need to resolve - feel free to weigh in over at #1521.

[petrelharp]

You'll want to make this clear in the QC issue, so whoever QCs it can follow along.

[petrelharp]

I see no other issues with this PR - hoepfully we can get that sorted soon so we can merge this!

[petrelharp]

Hm, actually I missed a legit non-Ensembl-related error: it doesn't like Gorilla gorilla gorilla as a species name:

> FAILED tests/test_GorGor.py::TestSpeciesData::test_name_basics - AssertionError: assert False
>       assert utils.is_valid_species_name(self.species.name)

So we need to either (a) change the species name to Gorilla gorilla or (b) change the validation code to accept subspecies. What do you think, @ChristianHuber ?

[ChristianHuber]

Changing the species name to Gorilla gorilla is fine! Christian

…

On Tue, Oct 10, 2023 at 9:42 PM Peter Ralph ***@***.***> wrote: Hm, actually I missed a legit non-Ensembl-related error: it doesn't like Gorilla gorilla gorilla as a species name: > FAILED tests/test_GorGor.py::TestSpeciesData::test_name_basics - AssertionError: assert False > assert utils.is_valid_species_name(self.species.name) So we need to either (a) change the species name to Gorilla gorilla or (b) change the validation code <https://github.com/popsim-consortium/stdpopsim/blob/main/stdpopsim/utils.py#L59> to accept subspecies. What do you think, @ChristianHuber <https://github.com/ChristianHuber> ? — Reply to this email directly, view it on GitHub <#1517 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARB267XKIJE3FSSOA7C4UTX6X2R3AVCNFSM6AAAAAA45FYUKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGYYDIMRQGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[petrelharp]

Thanks! I've rebased this to make the tests run correctly. Edit: hm, they didn't, actually. But we've got to figure out the Ensembl thing anyhow. Edit: NOW they work.