Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch firmware from fwupd in advance #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fetch firmware from fwupd in advance #64

wants to merge 1 commit into from

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Aug 30, 2019

Firmware from fwupd, when updates are available, will be fetched in advance, before it is shown in the UI.

Closes #59

@mmstick mmstick force-pushed the cache branch 2 times, most recently from 31cd76c to 005bf42 Compare August 30, 2019 23:33
@brs17 brs17 requested review from jackpot51 and a team September 4, 2019 18:25
@brs17
Copy link

brs17 commented Sep 4, 2019

@mmstick to properly fix #59 , shouldn't System76 provided firmware also be fetched in advance?

@mmstick
Copy link
Member Author

mmstick commented Sep 4, 2019

I think it's already being cached by the firmware daemon

@brs17
Copy link

brs17 commented Sep 4, 2019

That is not currently the case with thelio-io boards.

@mmstick
Copy link
Member Author

mmstick commented Sep 4, 2019

Seems that it should be. The main.hex file is downloaded at the time the metadata is downloaded. I think the daemon is redownloading it a second time.

@mmstick
Copy link
Member Author

mmstick commented Sep 4, 2019

Actually, this might be because pop-os/system76-firmware#19 isn't merged yet.

jackpot51
jackpot51 previously approved these changes Sep 5, 2019
Firmware from fwupd, when updates are available, will be fetched in advance, before it is shown in the UI.

Closes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download firmware before prompting to update
3 participants