Fix: extra transactions added in realtime #1126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The realtime sync functions in two stages, one concurrent stage to extract chain information corresponding to a block such as logs, call traces, transactions, and transaction receipts. This stage does as much filtering as possible but doesn't have access to all factory addresses.
The next stage is serial, and factory addresses are available. The logs and call traces are re-filtered but transactions and transaction receipts are not. This is causing extra transactions to be added to the database.
I fixed this issues by re-filtering transactions and transaction receipts in the second stage
handleBlock()
.