Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Preserve scalar in more places #18898

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Sep 24, 2024
@coastalwhite coastalwhite changed the title refactor: Preserve scalar in min/max_horizontal refactor: Preserve scalar in more places Sep 24, 2024
@ritchie46
Copy link
Member

I will wait until after the patch. ^^

@ritchie46
Copy link
Member

Alright, let's continue with this one. Can you rebase?

@coastalwhite coastalwhite force-pushed the refactor/more-scalar-opts branch 2 times, most recently from c267391 to cf5ea38 Compare September 27, 2024 15:44
@ritchie46 ritchie46 merged commit 27e2607 into pola-rs:main Sep 27, 2024
18 checks passed
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 61.33333% with 29 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (3904774) to head (395fdb0).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/column/compare.rs 27.02% 27 Missing ⚠️
crates/polars-python/src/dataframe/general.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18898      +/-   ##
==========================================
- Coverage   79.86%   79.86%   -0.01%     
==========================================
  Files        1523     1524       +1     
  Lines      207504   207546      +42     
  Branches     2904     2904              
==========================================
+ Hits       165720   165747      +27     
- Misses      41237    41252      +15     
  Partials      547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite deleted the refactor/more-scalar-opts branch September 27, 2024 17:35
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants