fix(python): Improve join argument checks

[mcrumiller]

Closes #18842 and closes #18846.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (f08885c) to head (db3a52c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18847      +/-   ##
==========================================
+ Coverage   79.85%   79.87%   +0.01%     
==========================================
  Files        1518     1518              
  Lines      205637   205647      +10     
  Branches     2893     2895       +2     
==========================================
+ Hits       164210   164258      +48     
+ Misses      40879    40841      -38     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mcrumiller]

@stinodego I don't suppose there's a way to deprecate a parameter in only certain circumstances? Suddenly raising when on is supplied to a cross join is definitely a change in behavior, even though on is an unused parameter in that case.

[ritchie46]

Thanks @mcrumiller.

[stinodego]

@stinodego I don't suppose there's a way to deprecate a parameter in only certain circumstances? Suddenly raising when on is supplied to a cross join is definitely a change in behavior, even though on is an unused parameter in that case.

There is, but you would have to 'manually' do this with the issue_deprecation_warning util.