Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Keep scalar in more places #18775

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@coastalwhite coastalwhite changed the title Refactor/column scalar opts refactor: Keep scalar in more places Sep 16, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Sep 16, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 33.22148% with 199 lines in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (a53bf03) to head (5be5abb).
Report is 105 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/datatypes/any_value.rs 29.62% 76 Missing ⚠️
crates/polars-core/src/frame/mod.rs 0.00% 61 Missing ⚠️
py-polars/polars/dataframe/frame.py 7.14% 13 Missing ⚠️
crates/polars-core/src/frame/column/mod.rs 86.04% 6 Missing ⚠️
...tes/polars-core/src/series/implementations/date.rs 25.00% 6 Missing ⚠️
py-polars/polars/lazyframe/frame.py 14.28% 6 Missing ⚠️
crates/polars-python/src/dataframe/general.rs 0.00% 5 Missing ⚠️
.../polars-core/src/series/implementations/boolean.rs 0.00% 4 Missing ⚠️
...s/polars-core/src/series/implementations/floats.rs 0.00% 4 Missing ⚠️
...ates/polars-core/src/series/implementations/mod.rs 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18775      +/-   ##
==========================================
- Coverage   79.86%   79.79%   -0.07%     
==========================================
  Files        1517     1518       +1     
  Lines      205533   205758     +225     
  Branches     2892     2899       +7     
==========================================
+ Hits       164142   164186      +44     
- Misses      40843    41024     +181     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite marked this pull request as ready for review September 17, 2024 10:38
@ritchie46 ritchie46 merged commit ea7953e into pola-rs:main Sep 23, 2024
27 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants