[Supplier] Add MsgUpdateParam to application module

config.yml

@@ -167,7 +167,7 @@ genesis:
         max_delegated_gateways: "7"
         min_stake:
           # TODO_MAINNET: Determine realistic amount for minimum application stake amount.
-          amount: "1000000" # 1 POKT
+          amount: "100000000" # 100 POKT
           denom: upokt
       applicationList:
         - address: pokt1mrqt5f7qh8uxs27cjm9t7v9e74a9vvdnq5jva4
@@ -179,7 +179,7 @@ genesis:
           stake:
             # NB: This value should be exactly 1upokt smaller than the value in
             # `supplier1_stake_config.yaml` so that the stake command causes a state change.
-            amount: "1000068"
+            amount: "100000068" # ~100 POKT
             denom: upokt
         - address: pokt1ad28jdap2zfanjd7hpkh984yveney6k9a42man
           delegatee_gateway_addresses: []
@@ -190,7 +190,7 @@ genesis:
           stake:
             # NB: This value should be exactly 1upokt smaller than the value in
             # `supplier1_stake_config.yaml` so that the stake command causes a state change.
-            amount: "1000068"
+            amount: "100000068" # ~100 POKT
             denom: upokt
     supplier:
       supplierList:

pkg/crypto/rings/client.go

@@ -46,6 +46,7 @@ type ringClient struct {
 // - polylog.Logger
 // - client.ApplicationQueryClient
 // - client.AccountQueryClient
+// - client.SharedQueryClient
 func NewRingClient(deps depinject.Config) (_ crypto.RingClient, err error) {
 	rc := new(ringClient)
 

proto/poktroll/supplier/tx.proto

@@ -1,4 +1,5 @@
 syntax = "proto3";
+
 package poktroll.supplier;
 
 option go_package = "github.com/pokt-network/poktroll/x/supplier/types";
@@ -9,33 +10,32 @@ import "cosmos/msg/v1/msg.proto";
 import "cosmos_proto/cosmos.proto";
 import "gogoproto/gogo.proto";
 import "cosmos/base/v1beta1/coin.proto";
-
 import "poktroll/supplier/params.proto";
 import "poktroll/shared/service.proto";
 
-
 // Msg defines the Msg service.
 service Msg {
   option (cosmos.msg.v1.service) = true;
-
+  
   // UpdateParams defines a (governance) operation for updating the module
   // parameters. The authority defaults to the x/gov module account.
   rpc UpdateParams    (MsgUpdateParams   ) returns (MsgUpdateParamsResponse   );
   rpc StakeSupplier   (MsgStakeSupplier  ) returns (MsgStakeSupplierResponse  );
   rpc UnstakeSupplier (MsgUnstakeSupplier) returns (MsgUnstakeSupplierResponse);
+  rpc UpdateParam     (MsgUpdateParam    ) returns (MsgUpdateParamResponse    );
 }
 // MsgUpdateParams is the Msg/UpdateParams request type.
 message MsgUpdateParams {
-  option (cosmos.msg.v1.signer) = "authority";
-  option (amino.name) = "poktroll/x/supplier/MsgUpdateParams";
-
+  option (cosmos.msg.v1.signer) =                           "authority";
+  option           (amino.name) = "poktroll/x/supplier/MsgUpdateParams";
+  
   // authority is the address that controls the module (defaults to x/gov unless overwritten).
   string authority = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
 
   // TODO_IMPROVE(#322): The requirement to provide all params is adopted from the
   // latest Cosmos SDK version. We should look into either improving this ourselves
   // or seeing if it is on their roadmap.
-
+  
   // params defines the x/supplier parameters to update.
   // NOTE: All parameters must be supplied.
   Params params = 2 [(gogoproto.nullable) = false, (amino.dont_omitempty) = true];
@@ -47,22 +47,37 @@ message MsgUpdateParamsResponse {}
 
 message MsgStakeSupplier {
   option (cosmos.msg.v1.signer) = "signer"; // https://docs.cosmos.network/main/build/building-modules/messages-and-queries
-
-  string signer = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the message signer (i.e. owner or operator)
-  string owner_address = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the owner (i.e. custodial, staker)
-  string operator_address = 3 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the operator (i.e. provider, non-custodial)
-  cosmos.base.v1beta1.Coin stake = 4; // The total amount of uPOKT the supplier has staked. Must be ≥ to the current amount that the supplier has staked (if any)
-  repeated poktroll.shared.SupplierServiceConfig services = 5; // The list of services this supplier is staked to provide service for
+           string                                signer           = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the message signer (i.e. owner or operator)
+           string                                owner_address    = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the owner (i.e. custodial, staker)
+           string                                operator_address = 3 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the operator (i.e. provider, non-custodial)
+           cosmos.base.v1beta1.Coin              stake            = 4; // The total amount of uPOKT the supplier has staked. Must be ≥ to the current amount that the supplier has staked (if any)
+  repeated poktroll.shared.SupplierServiceConfig services         = 5; // The list of services this supplier is staked to provide service for
 }
 
 message MsgStakeSupplierResponse {}
 
 message MsgUnstakeSupplier {
   option (cosmos.msg.v1.signer) = "signer";
-
-  string signer = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the message signer (i.e. owner or operator)
+  string signer           = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the message signer (i.e. owner or operator)
   string operator_address = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the operator (i.e. provider, non-custodial)
 }
 
 message MsgUnstakeSupplierResponse {}
 
+// MsgUpdateParam is the Msg/UpdateParam request type to update a single param.
+message MsgUpdateParam {
+  option (cosmos.msg.v1.signer) = "authority";
+
+  // authority is the address that controls the module (defaults to x/gov unless overwritten).
+  string authority = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
+
+  string name      = 2;
+  oneof asType {
+    cosmos.base.v1beta1.Coin as_coin = 3;
+  }
+}
+
+message MsgUpdateParamResponse {
+  Params params = 1;
+}
+

tests/integration/application/min_stake_test.go

@@ -0,0 +1,177 @@
+package application
+
+import (
+	"context"
+	"testing"
+
+	cosmoslog "cosmossdk.io/log"
+	"cosmossdk.io/math"
+	cosmostypes "github.com/cosmos/cosmos-sdk/types"
+	banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
+	"github.com/stretchr/testify/require"
+	"github.com/stretchr/testify/suite"
+
+	"github.com/pokt-network/poktroll/app/volatile"
+	"github.com/pokt-network/poktroll/cmd/poktrolld/cmd"
+	_ "github.com/pokt-network/poktroll/pkg/polylog/polyzero"
+	"github.com/pokt-network/poktroll/testutil/keeper"
+	testproof "github.com/pokt-network/poktroll/testutil/proof"
+	"github.com/pokt-network/poktroll/testutil/sample"
+	apptypes "github.com/pokt-network/poktroll/x/application/types"
+	prooftypes "github.com/pokt-network/poktroll/x/proof/types"
+	sessiontypes "github.com/pokt-network/poktroll/x/session/types"
+	sharedtypes "github.com/pokt-network/poktroll/x/shared/types"
+)
+
+type applicationMinStakeTestSuite struct {
+	suite.Suite
+
+	ctx     context.Context
+	keepers keeper.TokenomicsModuleKeepers
+
+	serviceId,
+	appBech32,
+	supplierBech32 string
+
+	appStake *cosmostypes.Coin
+
+	numRelays,
+	numComputeUnitsPerRelay uint64
+}
+
+func TestApplicationMinStakeTestSuite(t *testing.T) {
+	cmd.InitSDKConfig()
+
+	suite.Run(t, new(applicationMinStakeTestSuite))
+}
+
+func (s *applicationMinStakeTestSuite) SetupTest() {
+	s.keepers, s.ctx = keeper.NewTokenomicsModuleKeepers(s.T(), cosmoslog.NewNopLogger())
+
+	s.serviceId = "svc1"
+	s.appBech32 = sample.AccAddress()
+	s.supplierBech32 = sample.AccAddress()
+	s.appStake = &apptypes.DefaultMinStake
+	s.numRelays = 10
+	s.numComputeUnitsPerRelay = 1
+
+	// Set block height to 1.
+	s.ctx = cosmostypes.UnwrapSDKContext(s.ctx).WithBlockHeight(1)
+}
+
+func (s *applicationMinStakeTestSuite) TestAppCannotStakeLessThanMinStake() {
+	s.T().Skip("this case is well covered in x/application/keeper/msg_server_stake_application_test.go")
+}
+
+func (s *applicationMinStakeTestSuite) TestAppIsUnbondedIfBelowMinStakeWhenSettling() {
+	// Assert that the application's initial bank balance is 0.
+	appBalance := s.getAppBalance()
+	require.Equal(s.T(), int64(0), appBalance.Amount.Int64())
+
+	// Add service 1
+	s.addService()
+
+	// Stake an application for service 1 with min stake.
+	s.stakeApp()
+
+	// Stake a supplier for service 1.
+	s.stakeSupplier()
+
+	// Get the session header.
+	sessionHeader := s.getSessionHeader()
+
+	// Create a claim whose settlement amount drops the application below min stake
+	claim := s.getClaim(sessionHeader)
+
+	// Process TLMs for the claim.
+	err := s.keepers.Keeper.ProcessTokenLogicModules(s.ctx, claim)
+	require.NoError(s.T(), err)
+
+	// Assert that the application was unbonded.
+	_, isAppFound := s.keepers.ApplicationKeeper.GetApplication(s.ctx, s.appBech32)
+	require.False(s.T(), isAppFound)
+
+	// Assert that the application's stake was returned to its bank balance.
+	expectedAppBurn := math.NewInt(int64(s.numRelays * s.numComputeUnitsPerRelay * sharedtypes.DefaultComputeUnitsToTokensMultiplier))
+	expectedAppBalance := s.appStake.SubAmount(expectedAppBurn)
+	appBalance = s.getAppBalance()
+	require.Equal(s.T(), expectedAppBalance.Amount.Int64(), appBalance.Amount.Int64())
+
+}
+
+// addService adds the test service to the service module state.
+func (s *applicationMinStakeTestSuite) addService() {
+	s.keepers.ServiceKeeper.SetService(s.ctx, sharedtypes.Service{
+		Id:                   s.serviceId,
+		ComputeUnitsPerRelay: 1,
+		OwnerAddress:         sample.AccAddress(), // random address.
+	})
+}
+
+// stakeApp stakes an application for service 1 with min stake.
+func (s *applicationMinStakeTestSuite) stakeApp() {
+	s.keepers.ApplicationKeeper.SetApplication(s.ctx, apptypes.Application{
+		Address:        s.appBech32,
+		Stake:          s.appStake,
+		ServiceConfigs: []*sharedtypes.ApplicationServiceConfig{{ServiceId: s.serviceId}},
+	})
+}
+
+// stakeSupplier stakes a supplier for service 1.
+func (s *applicationMinStakeTestSuite) stakeSupplier() {
+	// TODO_UPNEXT(@bryanchriswhite, #612): Replace supplierStake with suppleirtypes.DefaultMinStake.
+	supplierStake := cosmostypes.NewInt64Coin(volatile.DenomuPOKT, 1000000) // 1 POKT.
+	s.keepers.SupplierKeeper.SetSupplier(s.ctx, sharedtypes.Supplier{
+		OwnerAddress:    s.supplierBech32,
+		OperatorAddress: s.supplierBech32,
+		Stake:           &supplierStake,
+		Services: []*sharedtypes.SupplierServiceConfig{
+			{
+				ServiceId: s.serviceId,
+				RevShare: []*sharedtypes.ServiceRevenueShare{
+					{
+						Address:            s.supplierBech32,
+						RevSharePercentage: 1,
+					},
+				},
+			},
+		},
+	})
+}
+
+// getSessionHeader gets the session header for the test session.
+func (s *applicationMinStakeTestSuite) getSessionHeader() *sessiontypes.SessionHeader {
+	sdkCtx := cosmostypes.UnwrapSDKContext(s.ctx)
+	currentHeight := sdkCtx.BlockHeight()
+	sessionRes, err := s.keepers.SessionKeeper.GetSession(s.ctx, &sessiontypes.QueryGetSessionRequest{
+		ApplicationAddress: s.appBech32,
+		ServiceId:          s.serviceId,
+		BlockHeight:        currentHeight,
+	})
+	require.NoError(s.T(), err)
+
+	return sessionRes.GetSession().GetHeader()
+}
+
+// getClaim creates a claim whose settlement amount drops the application below min stake.
+func (s *applicationMinStakeTestSuite) getClaim(
+	sessionHeader *sessiontypes.SessionHeader,
+) *prooftypes.Claim {
+	claimRoot := testproof.SmstRootWithSumAndCount(s.numRelays*s.numComputeUnitsPerRelay, s.numRelays)
+
+	return &prooftypes.Claim{
+		SupplierOperatorAddress: s.supplierBech32,
+		SessionHeader:           sessionHeader,
+		RootHash:                claimRoot,
+	}
+}
+
+// getAppBalance returns the bank module balance for the application.
+func (s *applicationMinStakeTestSuite) getAppBalance() *cosmostypes.Coin {
+	appBalRes, err := s.keepers.BankKeeper.Balance(s.ctx, &banktypes.QueryBalanceRequest{
+		Address: s.appBech32, Denom: volatile.DenomuPOKT,
+	})
+	require.NoError(s.T(), err)
+
+	return appBalRes.GetBalance()
+}