[DifficultyHash] Prepare for difficulty multiplier usage #836

red-0ne · 2024-09-24T23:03:56Z

Summary

This PR prepares for claimed amount calculation to use the RelayDifficultyMultiplier.

It removes the RelayDifficultyTargetHash proof param.
Replace prooftypes.DefaultRelayDifficultyTargetHash occurrences with protocol.BaseRelayDifficultyHashBz.
Moves the RleayMiningDifficulty logic to the service module due to cyclic dependencies.
Rename num_compute_units to num_claimed_compute_units and add num_estimated_compute_units and claimed_amount_upokt
Remove the no longer used tokenomics querier to retrieve a service difficulty target hash.

The PR is only renaming and moving of files most (~13200LOC) changes are auto-generated code.

Type of change

Select one or more from the following:

New feature, functionality or library
Consensus breaking; add the consensus-breaking label if so. See [Infra] Automatically add the consensus-breaking label #791 for details
Bug fix
Code health or cleanup
Documentation
Other (specify)

Testing

Documentation: make docusaurus_start; only needed if you make doc changes
Unit Tests: make go_develop_and_test
LocalNet E2E Tests: make test_e2e
DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

I have tested my changes using the available tooling
I have commented my code
I have performed a self-review of my own code; both comments & source code
I create and reference any new tickets, if applicable
I have left TODOs throughout the codebase, if applicable

…ty-proportional-rewards

bryanchriswhite

bryanchriswhite · 2024-09-30T07:53:55Z

e2e/tests/update_params.feature

Please merge main, this feature doesn't exist anymore. 😅

Olshansk

Will TAL after merged with main

…ty-proportional-rewards

bryanchriswhite

bryanchriswhite

Preemptively approving! 🙌

Just a couple questions and small suggestions - otherwise this LGTM! 🚢

bryanchriswhite · 2024-10-08T06:38:22Z

docusaurus/docs/protocol/governance/params.md

Thanks for spotting this! 🙏

I've opened #864 to fix the underlying issue (as well as another).

testutil/integration/app.go

bryanchriswhite · 2024-10-08T06:49:55Z

testutil/testclient/testqueryclients/servicequerier.go

+	t.Cleanup(func() {
+		delete(relayDifficultyTargets, serviceId)
+	})


👌 Nice. 😎

x/proof/types/message_update_param_test.go

bryanchriswhite · 2024-10-08T08:08:06Z

x/service/types/genesis_test.go

 				// this line is used by starport scaffolding # types/genesis/validField
 			},
 			expectedErr: nil,
 		},
+		{
+			desc: "invalid - duplicated relayMiningDifficulty",


x/service/types/genesis.go

…ty-proportional-rewards

github-actions · 2024-10-09T23:48:26Z

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 836)
Grafana network dashboard for devnet-issue-836

Olshansky declared code review bankruptcy

…burning * pokt/main: [DifficultyHash] Prepare for difficulty multiplier usage (#836) [Application] Enforce minimum stake when staking (#847)

…application * issues/612/application/burning: (94 commits) fix: linter error chore: quick fixes [DifficultyHash] Prepare for difficulty multiplier usage (#836) [Application] Enforce minimum stake when staking (#847) Empty commit [Tokenomics] Prevent GMR to produce zero values (#866) Empty commit chore: regenerate protobufs fix: linter error Empty commit chore: review feedback improvements Empty commit Empty commit fix: linter errors fix: typo chore: review feedback improvements chore: reconcile PreGeneratedAccountIterator#MustNext() chore: add review feedback TODOs Empty commit test: simplify coin equality assertions ... # Conflicts: # x/application/keeper/msg_server_stake_application_test.go # x/application/keeper/msg_server_unstake_application.go # x/application/keeper/msg_server_unstake_application_test.go # x/application/keeper/unbond_applications.go

## Summary This PR incorporated the mining difficulty into the claim reward calculation. * Encapsulates the claimed tokens into a `claim.GetClaimeduPOKT(params, difficulty)` * Implements a test to assert that the difficulty based rewards are proportional to the off-chain relays served. * Removes unused `min_relay_difficulty_bits` gov. param. It is based on the preparation work of PR #836. ## Issue - #781 - #758 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Bryan White <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

* issues/612/shared/refresh: (46 commits) test: supplier up-staking from below min. stake fix: linter error fix: flaky test [Application] Enforce minimum stake when burning (#848) Empty commit chore: review feedback improvements chore: regenerate protobufs chore: review feedback improvements test: fix application min stake integration test chore: review feedback improvements Empty commit fix: linter error chore: quick fixes [DifficultyHash] Prepare for difficulty multiplier usage (#836) [Application] Enforce minimum stake when staking (#847) Empty commit [Tokenomics] Prevent GMR to produce zero values (#866) Empty commit [Application] Add `min_stake` application module param (#845) chore: regenerate protobufs ...

* issues/612/proof/refresh: (46 commits) test: supplier up-staking from below min. stake fix: linter error fix: flaky test [Application] Enforce minimum stake when burning (#848) Empty commit chore: review feedback improvements chore: regenerate protobufs chore: review feedback improvements test: fix application min stake integration test chore: review feedback improvements Empty commit fix: linter error chore: quick fixes [DifficultyHash] Prepare for difficulty multiplier usage (#836) [Application] Enforce minimum stake when staking (#847) Empty commit [Tokenomics] Prevent GMR to produce zero values (#866) Empty commit [Application] Add `min_stake` application module param (#845) chore: regenerate protobufs ... # Conflicts: # x/service/types/errors.go

…-uint64 * issues/612/service/refresh: (46 commits) test: supplier up-staking from below min. stake fix: linter error fix: flaky test [Application] Enforce minimum stake when burning (#848) Empty commit chore: review feedback improvements chore: regenerate protobufs chore: review feedback improvements test: fix application min stake integration test chore: review feedback improvements Empty commit fix: linter error chore: quick fixes [DifficultyHash] Prepare for difficulty multiplier usage (#836) [Application] Enforce minimum stake when staking (#847) Empty commit [Tokenomics] Prevent GMR to produce zero values (#866) Empty commit [Application] Add `min_stake` application module param (#845) chore: regenerate protobufs ...

**This is a repost of PR #840 which did not get merged into main** ## Summary This PR incorporated the mining difficulty into the claim reward calculation. * Encapsulates the claimed tokens into a `claim.GetClaimeduPOKT(params, difficulty)` * Implements a test to assert that the difficulty based rewards are proportional to the off-chain relays served. * Removes unused `min_relay_difficulty_bits` gov. param. It is based on the preparation work of PR #836. ## Issue - #781 - #758 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable

…ed-params * pokt/main: [On-Chain] Refactor `uint64` type individual param update logic (#863) [Service] Refresh service module params logic (#861) [Proof] Refresh proof module params logic (#851) [Shared] Refresh shared module params logic (#852) [Docs] Fix example of how to set rev share precentage (#877) [Tokenomics] Implement difficulty proportional rewards (#880) [Supplier] Enforce minimum stake when staking (#857) [Supplier] Add `min_stake` supplier module param (#850) [Supplier] Add `MsgUpdateParam` to application module (#849) [Application] Enforce minimum stake when burning (#848) [DifficultyHash] Prepare for difficulty multiplier usage (#836) [Application] Enforce minimum stake when staking (#847) [Tokenomics] Prevent GMR to produce zero values (#866)

* pokt/main: [On-Chain] Refactor `uint64` type individual param update logic (#863) [Service] Refresh service module params logic (#861) [Proof] Refresh proof module params logic (#851) [Shared] Refresh shared module params logic (#852) [Docs] Fix example of how to set rev share precentage (#877) [Tokenomics] Implement difficulty proportional rewards (#880) [Supplier] Enforce minimum stake when staking (#857) [Supplier] Add `min_stake` supplier module param (#850) [Supplier] Add `MsgUpdateParam` to application module (#849) [Application] Enforce minimum stake when burning (#848) [DifficultyHash] Prepare for difficulty multiplier usage (#836) [Application] Enforce minimum stake when staking (#847) [Tokenomics] Prevent GMR to produce zero values (#866)

refactor: Prepare for difficulty multiplier

e0ddafb

red-0ne added code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Sep 24, 2024

red-0ne added this to the Shannon Beta TestNet Launch milestone Sep 24, 2024

red-0ne requested review from bryanchriswhite and Olshansk September 24, 2024 23:03

red-0ne self-assigned this Sep 24, 2024

red-0ne added 2 commits September 25, 2024 01:06

fix: Remove unused function

2ebf97e

Merge remote-tracking branch 'origin/main' into feat/prepare-difficul…

1c19848

…ty-proportional-rewards

red-0ne mentioned this pull request Sep 26, 2024

[Tokenomics] Implement difficulty proportional rewards #840

Merged

14 tasks

bryanchriswhite reviewed Sep 30, 2024

View reviewed changes

Olshansk previously requested changes Sep 30, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into feat/prepare-difficul…

6fa8d62

…ty-proportional-rewards

red-0ne requested review from Olshansk and bryanchriswhite October 4, 2024 14:07

bryanchriswhite reviewed Oct 7, 2024

View reviewed changes

bryanchriswhite approved these changes Oct 8, 2024

View reviewed changes

red-0ne added 2 commits October 10, 2024 00:34

Merge remote-tracking branch 'origin/main' into feat/prepare-difficul…

12de8d6

…ty-proportional-rewards

chore: Address review change requests

0e17093

red-0ne added the devnet-test-e2e label Oct 9, 2024

github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Oct 9, 2024

red-0ne added 3 commits October 10, 2024 02:54

fix: new service difficulty created

ae6ef5a

Empty commit

b8937ca

Empty commit

10140b9

red-0ne merged commit 879401e into main Oct 10, 2024
13 checks passed

red-0ne mentioned this pull request Oct 14, 2024

[Tokenomics] Implement difficulty proportional rewards #880

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DifficultyHash] Prepare for difficulty multiplier usage #836

[DifficultyHash] Prepare for difficulty multiplier usage #836

red-0ne commented Sep 24, 2024

bryanchriswhite left a comment

bryanchriswhite Sep 30, 2024

Olshansk left a comment

bryanchriswhite left a comment

bryanchriswhite left a comment

bryanchriswhite Oct 8, 2024

bryanchriswhite Oct 8, 2024

bryanchriswhite Oct 8, 2024

github-actions bot commented Oct 9, 2024

[DifficultyHash] Prepare for difficulty multiplier usage #836

[DifficultyHash] Prepare for difficulty multiplier usage #836

Conversation

red-0ne commented Sep 24, 2024

Summary

Type of change

Testing

Sanity Checklist

bryanchriswhite left a comment

Choose a reason for hiding this comment

bryanchriswhite Sep 30, 2024

Choose a reason for hiding this comment

Olshansk left a comment

Choose a reason for hiding this comment

bryanchriswhite left a comment

Choose a reason for hiding this comment

bryanchriswhite left a comment

Choose a reason for hiding this comment

bryanchriswhite Oct 8, 2024

Choose a reason for hiding this comment

bryanchriswhite Oct 8, 2024

Choose a reason for hiding this comment

bryanchriswhite Oct 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 9, 2024