chore: remove unnecessary proof param asTypes

pokt-network · Oct 7, 2024 · 50ea8ed · 50ea8ed
1 parent c5a9b94
commit 50ea8ed
Show file tree

Hide file tree

Showing 6 changed files with 142 additions and 455 deletions.
diff --git a/api/poktroll/proof/tx.pulsar.go b/api/poktroll/proof/tx.pulsar.go
diff --git a/proto/poktroll/proof/tx.proto b/proto/poktroll/proof/tx.proto
@@ -59,8 +59,6 @@ message MsgUpdateParam {
   // specified in the `Params`` message in `proof/params.proto.`
   string name = 2;
   oneof as_type {
-    string as_string = 3 [(gogoproto.jsontag) = "as_string"];
-    int64 as_int64 = 6 [(gogoproto.jsontag) = "as_int64"];
     bytes as_bytes = 7 [(gogoproto.jsontag) = "as_bytes"];
     float as_float = 8 [(gogoproto.jsontag) = "as_float"];
     cosmos.base.v1beta1.Coin as_coin = 9 [(gogoproto.jsontag) = "as_coin"];

diff --git a/testutil/integration/suites/param_configs.go b/testutil/integration/suites/param_configs.go
@@ -210,9 +210,6 @@ var (
 			ProofSubmissionFee:        &ValidProofSubmissionFeeCoin,
 		},
 		ParamTypes: map[ParamType]any{
-			ParamTypeUint64:  prooftypes.MsgUpdateParam_AsInt64{},
-			ParamTypeInt64:   prooftypes.MsgUpdateParam_AsInt64{},
-			ParamTypeString:  prooftypes.MsgUpdateParam_AsString{},
 			ParamTypeBytes:   prooftypes.MsgUpdateParam_AsBytes{},
 			ParamTypeFloat32: prooftypes.MsgUpdateParam_AsFloat{},
 			ParamTypeCoin:    prooftypes.MsgUpdateParam_AsCoin{},

diff --git a/x/proof/types/message_update_param.go b/x/proof/types/message_update_param.go
@@ -14,10 +14,6 @@ func NewMsgUpdateParam(authority string, name string, value any) (*MsgUpdatePara
 	var valueAsType isMsgUpdateParam_AsType
 
 	switch v := value.(type) {
-	case string:
-		valueAsType = &MsgUpdateParam_AsString{AsString: v}
-	case int64:
-		valueAsType = &MsgUpdateParam_AsInt64{AsInt64: v}
 	case []byte:
 		valueAsType = &MsgUpdateParam_AsBytes{AsBytes: v}
 	case *sdk.Coin:

diff --git a/x/proof/types/message_update_param_test.go b/x/proof/types/message_update_param_test.go
@@ -20,7 +20,7 @@ func TestMsgUpdateParam_ValidateBasic(t *testing.T) {
 			msg: MsgUpdateParam{
 				Authority: "invalid_address",
 				Name:      "", // Doesn't matter for this test
-				AsType:    &MsgUpdateParam_AsInt64{AsInt64: 1},
+				AsType:    &MsgUpdateParam_AsFloat{AsFloat: 0},
 			},
 
 			expectedErr: ErrProofInvalidAddress,
@@ -29,7 +29,7 @@ func TestMsgUpdateParam_ValidateBasic(t *testing.T) {
 			msg: MsgUpdateParam{
 				Authority: sample.AccAddress(),
 				Name:      "WRONG_relay_difficulty_target_hash",
-				AsType:    &MsgUpdateParam_AsInt64{AsInt64: 1},
+				AsType:    &MsgUpdateParam_AsFloat{AsFloat: 0},
 			},
 
 			expectedErr: ErrProofParamNameInvalid,
@@ -38,7 +38,7 @@ func TestMsgUpdateParam_ValidateBasic(t *testing.T) {
 			msg: MsgUpdateParam{
 				Authority: sample.AccAddress(),
 				Name:      ParamRelayDifficultyTargetHash,
-				AsType:    &MsgUpdateParam_AsString{AsString: "invalid"},
+				AsType:    &MsgUpdateParam_AsFloat{AsFloat: 0},
 			},
 			expectedErr: ErrProofParamInvalid,
 		}, {

diff --git a/x/proof/types/tx.pb.go b/x/proof/types/tx.pb.go