[Observability] refactor: remove error labels from metrics (#653)

telemetry/event_counters.go

@@ -59,7 +59,6 @@ func ProofRequirementCounter(
 	// Ensure the counter is not incremented if there was an error.
 	if err != nil {
 		incrementAmount = 0
-		labels = AppendErrLabel(err, labels...)
 	}
 
 	telemetry.IncrCounterWithLabels(
@@ -86,7 +85,6 @@ func ClaimComputeUnitsCounter(
 	// Ensure the counter is not incremented if there was an error.
 	if err != nil {
 		incrementAmount = 0
-		labels = AppendErrLabel(err, labels...)
 	}
 
 	telemetry.IncrCounterWithLabels(
@@ -113,7 +111,6 @@ func ClaimCounter(
 	// Ensure the counter is not incremented if there was an error.
 	if err != nil {
 		incrementAmount = 0
-		labels = AppendErrLabel(err, labels...)
 	}
 
 	telemetry.IncrCounterWithLabels(
@@ -153,13 +150,3 @@ func RelayEMAGauge(relayEMA uint64, serviceId string) {
 		labels,
 	)
 }
-
-// AppendErrLabel appends a label with the name "error" and a value of the error's
-// message to the given labels slice if the error is not nil.
-func AppendErrLabel(err error, labels ...metrics.Label) []metrics.Label {
-	if err == nil {
-		return labels
-	}
-
-	return append(labels, metrics.Label{Name: "error", Value: err.Error()})
-}