Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 issues and minor enhancement. #1485

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Fix 2 issues and minor enhancement. #1485

merged 3 commits into from
Nov 28, 2022

Conversation

jorgecuesta
Copy link
Contributor

Fix #1457;
Fix #1484;
Fix a high memory consumption that also is part of issue #1457.
Under the high load of requests (1000/rps or more), the RAM got crazy and scaled up to 40GB or close to that.
Now after the fix of #1457 with the worker pool, the node remains under 14GB of ram in my local tests.

@jessicadaugherty jessicadaugherty added bug Something isn't working enhancement New feature or request community Open to or owned by a non-core team member labels Oct 13, 2022
@oten91
Copy link
Contributor

oten91 commented Nov 18, 2022

Hey @jorgecuesta please rebase.

@oten91 oten91 deleted the branch pokt-network:thorny-devil November 22, 2022 21:52
@oten91 oten91 closed this Nov 22, 2022
@oten91 oten91 reopened this Nov 23, 2022
@oten91 oten91 changed the base branch from ethereal-wombat to staging November 23, 2022 15:12
@jorgecuesta
Fix pokt-network#1457; Fix pokt-network#1484;
8a78559 
Fix a high memory consumption that also is part of the issue pokt-network#1457.
Under high load of requests (1000/rps or more) the RAM got crazy and scale up to 40GB or close to that.
Now after the fix of pokt-network#1457 with the worker pool, the node remains under 14gb of ram in my local tests.
@jorgecuesta
remove idle timeout in favor to use default (5 seg) because otherwise…
3caaea5 
… keep cpu in high load.
@oten91 oten91 changed the base branch from staging to slim-squash November 28, 2022 14:28
oten91
oten91 suggested changes Nov 28, 2022
View reviewed changes
x/pocketcore/types/service.go Outdated Show resolved Hide resolved
@oten91
Copy link
Contributor

oten91 commented Nov 28, 2022

@jorgecuesta looks good, left you a comment

@oten91 oten91 changed the base branch from slim-squash to thorny-devil November 28, 2022 15:05
@oten91 oten91 merged commit 07ee13e into pokt-network:thorny-devil Nov 28, 2022
@reviewpad
Copy link

reviewpad bot commented Apr 18, 2023

AI-Generated Summary: This pull request includes 3 patches that address high memory consumption (#1457) and some improvements:

  1. Fix a high memory consumption issue that occurred under high load of requests (1000/rps or more) by adding a worker pool. This helps to maintain the memory usage below 14GB in local tests. Also, update tests to ensure the evidence worker's successful tasks are equal to the number of validators.

  2. Remove the idle timeout and use the default timeout (5 seconds) to prevent high CPU load.

  3. Replace hardcoded values for initializing the HTTP client with values from the GlobalPocketConfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oten91 oten91 oten91 requested changes

Assignees
No one assigned
Labels
bug Something isn't working community Open to or owned by a non-core team member enhancement New feature or request
Projects
V0 Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgecuesta @oten91 @jessicadaugherty