Skip to content

Commit

Permalink
Add a link to #1617 in the codebase (#1619)
Browse files Browse the repository at this point in the history
TODO(#1617): Check the return value of `Update` and handle errors
appropriately
  • Loading branch information
Olshansk authored Oct 2, 2024
1 parent 472862a commit 8003658
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion x/gov/keeper/subspace.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ package keeper

import (
"fmt"
"github.com/pokt-network/pocket-core/codec"
"os"

"github.com/pokt-network/pocket-core/codec"
sdk "github.com/pokt-network/pocket-core/types"
"github.com/pokt-network/pocket-core/x/gov/types"
)
Expand Down Expand Up @@ -213,6 +213,7 @@ func (k Keeper) ModifyParam(ctx sdk.Ctx, aclKey string, paramValue []byte, owner
k.Logger(ctx).Error(types.ErrSubspaceNotFound(types.ModuleName, subspaceName).Error())
os.Exit(1)
}
// TODO(#1617): Check the return value of `Update` and handle errors appropriately
_ = space.Update(ctx, []byte(paramKey), paramValue)
k.spaces[subspaceName] = space
// create the event
Expand Down

0 comments on commit 8003658

Please sign in to comment.