Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect timeout setting and clarify env var docs #29

Conversation

Maxitosh
Copy link
Contributor

@Maxitosh Maxitosh commented Apr 2, 2024

Github issue

#28

Description

  • Correct the chain config attribute for POKT request timeouts in relayer.go.
  • Disambiguate POKT_RPC_TIMEOUT usage in the quick onboarding guide to prevent setup confusion.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

- Correct the chain config attribute for POKT request timeouts in relayer.go
- Disambiguate `POKT_RPC_TIMEOUT` usage in the quick onboarding guide to prevent setup confusion
Copy link
Collaborator

@nodiesBlade nodiesBlade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch. Trivial change and we should be able to include this into 0.1.2

@nodiesBlade nodiesBlade merged commit 8e42c89 into pokt-network:main Apr 3, 2024
2 checks passed
@nodiesBlade
Copy link
Collaborator

nodiesBlade commented Apr 3, 2024

@Maxitosh how do you feel about following up with unit tests for this function? We have a mock config provider in relayer_test that you can use.

@nodiesBlade nodiesBlade self-assigned this Apr 3, 2024
@Maxitosh Maxitosh deleted the fix/timeout-config-and-docs-clarification branch April 3, 2024 03:50
@Maxitosh
Copy link
Contributor Author

Maxitosh commented Apr 3, 2024

@Maxitosh how do you feel about following up with unit tests for this function? We have a mock config provider in relayer_test that you can use.

Hey, @nodiesBlade

I'll need to spend some time getting familiar with the existing tests and the mocks.
Thanks for the suggestion! I'm happy to look into it.

@nodiesBlade nodiesBlade mentioned this pull request Apr 3, 2024
2 tasks
@nodiesBlade
Copy link
Collaborator

@Maxitosh how do you feel about following up with unit tests for this function? We have a mock config provider in relayer_test that you can use.

Hey, @nodiesBlade

I'll need to spend some time getting familiar with the existing tests and the mocks. Thanks for the suggestion! I'm happy to look into it.

If you need assistance, happy to pair or provide guidance! Thanks for the contribution

@nodiesBlade nodiesBlade mentioned this pull request Apr 4, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants