Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added placeholder file changelog #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rafee
Copy link

@rafee rafee commented May 2, 2020

Without this file, the library compilation and all subsequent commands fail. This pull request only creates that file, without content

@seronline
Copy link
Collaborator

the make-all-clean.sh script was not meant to install everything on to a mint system. The issue is a bit that the documentation doesn't have any reference to your script and back then we didn't use the wiki here for this matter. While I do not see anything wrong with your script I'd like to have a 2nd opinion from another code maintainer: @mfhaln what do you think? I'd merge it without going back to the PDF and change it

@seronline seronline self-assigned this May 4, 2020
@mfhaln
Copy link
Collaborator

mfhaln commented May 4, 2020

I agree with @seronline. I don't see an obvious issue with the request, so we can merge. but just to keep a record for future references, would you mind please updating ChangeLog with the updates.

@rafee
Copy link
Author

rafee commented May 4, 2020

Do you want me to close a recreate the pull request with an updated document? Also, what do you want me to update in the changelog? Are you referring to the root directory changelog?

@rafee rafee closed this May 6, 2020
@rafee
Copy link
Author

rafee commented May 6, 2020

I tried going back to docs, but I found the docs are in PDF file without any source latex or word document. While I may try to edit the pdf, it might break layout in unintended places.

@rafee rafee reopened this May 6, 2020
@mfhaln
Copy link
Collaborator

mfhaln commented May 6, 2020

Hi, sorry for taking longer to respond. Yes, I was referring to the ChangeLog in the root directory. it is a tex file and would just like brief summary points of the changes involved in the Pull request. No need to do any changes in the doc/ files as these have to do with examples and software design. AFAIS, your changes are to the make-all script which is not described in these documents. it was a script created for convenience but grew to be important part of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants