Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: remove obsolete code #6118

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Oct 1, 2024

There is a code that do nothing. It has not been finished when last logging cleanup has been made.


This change is Reviewable

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Oct 1, 2024
@grom72 grom72 requested review from janekmi and osalyk October 1, 2024 15:52
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 merged commit c347862 into pmem:master Oct 2, 2024
8 checks passed
@grom72 grom72 deleted the obsolete-no-use-log-pmemobj branch October 2, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants