common: extend SKIPed tests description

[grom72]

This change is 

[osalyk]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

[janekmi]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @grom72)

---

src/test/RUNTESTS.sh line 279 at r1 (raw file):

		ttype=$(intersection "$_testtype" "$req_testtype" "short medium long")
		[ -z "$ttype" ] && {
			echo "$UNITTEST_NAME: SKIP ($TEST/$REAL_FS/$BUILD$MCSTR$PROV$PM) test-type $testtype ($req_testtype required)"

I would say non of these is set in this context.

Code quote:

			echo "$UNITTEST_NAME: SKIP ($TEST/$REAL_FS/$BUILD$MCSTR$PROV$PM) test-type $testtype ($req_testtype required)"

---

src/test/tools/anonymous_mmap/check_max_mmap.sh line 32 at r1 (raw file):

function msg_skip() {
	echo "0" > "$FILE_MAX_DAX_DEVICES"
	echo "$0: SKIP ($TEST/$REAL_FS/$BUILD$MCSTR$PROV$PM): $*"

.

---

src/test/unittest/unittest.sh line 849 at r1 (raw file):

	msg "$UNITTEST_NAME: SKIP ($TEST/$REAL_FS/$BUILD$MCSTR$PROV$PM) required: overcommit_memory enabled and unlimited virtual memory"
	exit 0
}

It seems irrelevant now. Nobody uses it.

---

src/test/unittest/unittest.sh line 910 at r1 (raw file):

	msg "$UNITTEST_NAME: SKIP ($TEST/$REAL_FS/$BUILD$MCSTR$PROV$PM): Only supported on $1"
	exit 0
}

.

---

src/test/unittest/unittest.sh line 923 at r1 (raw file):

		fi
	done
}

.

---

src/test/unittest/unittest.sh line 1586 at r1 (raw file):

		exit 0
	fi
}

.

[grom72]

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @janekmi)

---

src/test/RUNTESTS.sh line 279 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I would say non of these is set in this context.

See example below

---

src/test/tools/anonymous_mmap/check_max_mmap.sh line 32 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

Old:

ctl_prefault/TEST0: SETUP (check/non-pmem/debug)
ctl_prefault/TEST0: SKIP: filesystem does not support fallocate

New:

ctl_prefault/TEST0: SETUP (check/non-pmem/debug)
ctl_prefault/TEST0: SKIP (check/non-pmem/debug): filesystem does not support fallocate

---

src/test/unittest/unittest.sh line 849 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

It seems irrelevant now. Nobody uses it.

But it is not a part of this PR

---

src/test/unittest/unittest.sh line 910 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

.

---

src/test/unittest/unittest.sh line 923 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

.

[grom72]

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @janekmi)

---

src/test/unittest/unittest.sh line 1586 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (9819db6) to head (451905f).
Report is 121 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6052   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files         133      133           
  Lines       19563    19563           
  Branches     3261     3261           
=======================================
  Hits        13708    13708           
  Misses       5855     5855           

[janekmi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)

---

src/test/RUNTESTS.sh line 279 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

See example below

I just uncommented the condition and the result looks as follows:

arch_flags/TEST0: SKIP (//) test-type check (all required)

Am I missing something?

---

src/test/tools/anonymous_mmap/check_max_mmap.sh line 32 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Old:

ctl_prefault/TEST0: SETUP (check/non-pmem/debug)
ctl_prefault/TEST0: SKIP: filesystem does not support fallocate

New:

ctl_prefault/TEST0: SETUP (check/non-pmem/debug)
ctl_prefault/TEST0: SKIP (check/non-pmem/debug): filesystem does not support fallocate

$ ./check_max_mmap.sh 
./check_max_mmap.sh: SKIP (//): DEVICE_DAX_PATH does not specify path to DAX device.

What am I missing?

---

src/test/unittest/unittest.sh line 285 at r1 (raw file):

		;;
	*)
		verbose_msg "$UNITTEST_NAME: SKIP ($TEST/$REAL_FS/$BUILD$MCSTR$PROV$PM) fs-type $FS (not configured)"

Verified. It works.

arch_flags/TEST0: SKIP (check/none/debug) fs-type none (not configured)
arch_flags/TEST0: SKIP (check/none/nondebug) fs-type none (not configured)
arch_flags/TEST0: SKIP (check/pmem/debug) fs-type pmem (not configured)
arch_flags/TEST0: SKIP (check/pmem/nondebug) fs-type pmem (not configured)
arch_flags/TEST0: SKIP (check/non-pmem/debug) fs-type non-pmem (not configured)
arch_flags/TEST0: SKIP (check/non-pmem/nondebug) fs-type non-pmem (not configured)
arch_flags/TEST0: SKIP (check/pmem/debug) fs-type any (not configured)
arch_flags/TEST0: SKIP (check/pmem/nondebug) fs-type any (not configured)

---

src/test/unittest/unittest.sh line 843 at r1 (raw file):

function require_unlimited_vm() {
	if grep -q "^mmu[[:blank:]]*: sv39" /proc/cpuinfo; then
		msg "$UNITTEST_NAME: SKIP ($TEST/$REAL_FS/$BUILD$MCSTR$PROV$PM) required: 4+ level virtual memory"

Since all the extended messages use the same variables as the one used above, the skip messages ought to be properly generated also in case of using the same exact variables from the function calls. At least as long as nothing overwrites these variables.

[grom72]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)

---

src/test/RUNTESTS.sh line 279 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I just uncommented the condition and the result looks as follows:

arch_flags/TEST0: SKIP (//) test-type check (all required)

Am I missing something?

So please do not uncomment ;) as this is not a part of this PR

---

src/test/tools/anonymous_mmap/check_max_mmap.sh line 32 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

$ ./check_max_mmap.sh 
./check_max_mmap.sh: SKIP (//): DEVICE_DAX_PATH does not specify path to DAX device.

What am I missing?

Done.

[janekmi]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

[grom72]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)

---

src/test/RUNTESTS.sh line 279 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

So please do not uncomment ;) as this is not a part of this PR

Done

[grom72]

Reviewed 1 of 2 files at r4.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)

[grom72]

Reviewed 1 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)

[janekmi]

Reviewed 1 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

[janekmi]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)