introduce posthog #367
introduce posthog #367
Conversation
zreigz
force-pushed
the
posthog
branch
2 times, most recently
from
011fce7
to
4d51f4e
Compare
| @@ -247,7 +250,25 @@ func (p *Plural) deploy(c *cli.Context) error { | |||
| fmt.Println("") | |||
| } | |||
| } | |||
|
|
|||
| for _, ch := range man.Charts { | |||
There was a problem hiding this comment.
We should send this info from the server if we want it in posthog, having the cli send it is error prone and could potentially cause failed installs
There was a problem hiding this comment.
We can't track the actual commands users execute server side since it doesn't know when somebody runs plural deploy. Having it in the CLI allows us to have a better metric of which commands people run, how often they run, and if they encountered an error when running the command. This can give us a metric of how many successful deploys have happened versus how many errors have occurred. It can also give us a timeline of a user's actions. For example, user deploys but runs into an error for app X, user then runs install to change a config and build for app X to fix that config, user then runs deploy again and it runs successfully.
Each command that a user executes and if it passes or fails is very important data so we can have a better idea of how many command executions pass versus fail and where they fail exactly.
| @@ -120,6 +121,17 @@ func (s *Scaffold) Execute(wk *wkspace.Workspace, force bool) error { | |||
| preflight.Sha = "" | |||
| } | |||
|
|
|||
| for _, ch := range wk.Charts { | |||
There was a problem hiding this comment.
Similarly, this is better to send server-side
pkg/bundle/installer.go
Outdated
| return err | ||
| } | ||
|
|
||
| if err := client.InstallRecipe(recipe.Id); err != nil { | ||
| posthogProperty.Error = fmt.Errorf("failed install recipe") |
There was a problem hiding this comment.
should we just add this to our existing error logging wrapper?
There was a problem hiding this comment.
I have moved error handling to tracked validator
Summary
Introduce posthog for plural bundle install, build, and deploy commands.
Labels
Test Plan
Checklist