Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conditions improvements #600

Merged
merged 14 commits into from
Jan 11, 2024
Merged

feat: Conditions improvements #600

merged 14 commits into from
Jan 11, 2024

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Jan 10, 2024

  • Rename current Ready condition to Synchronized. Synchronized will be used to indicate that resource was successfully reconciled. Ready will indicate actual resource status, i.e. it if was provisioned/created successfully.
  • Sync conditions from API to Cluster custom resource, including Ready condition.
  • Add Ready condition for GitRepository custom resource based on GitHealth (if pullable).
  • Add Ready condition for Provider custom resource based on its service components status (if all are running).
  • Fix bug that would cause Provider to be considered readonly even if it would be created by this controller (needed to mark it as non-readonly earlier in case some error occurs).
  • Sort conditions during tests to make them more stable.
  • Fix build and unit tests in CI.
Zrzut ekranu 2024-01-11 o 11 58 21

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Visit the preview URL for this PR (updated for commit 1c38315):

https://pluralsh-console--pr600-conditions-hip6zrho.web.app

(expires Thu, 18 Jan 2024 13:20:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@maciaszczykm maciaszczykm changed the title feat: Sync cluster conditions feat: Conditions improvements Jan 11, 2024
@maciaszczykm maciaszczykm added the enhancement New feature or request label Jan 11, 2024
@maciaszczykm maciaszczykm marked this pull request as ready for review January 11, 2024 12:49
@maciaszczykm maciaszczykm merged commit fd1afcd into master Jan 11, 2024
14 checks passed
@maciaszczykm maciaszczykm deleted the conditions branch January 11, 2024 14:04
snikch pushed a commit to snikch/plural-console that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants