Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show details for Ingress/Deployments in canary view #594

Merged
merged 6 commits into from
Jan 9, 2024
Merged

feat: Show details for Ingress/Deployments in canary view #594

merged 6 commits into from
Jan 9, 2024

Conversation

dogmar
Copy link
Collaborator

@dogmar dogmar commented Jan 8, 2024 •
edited
Loading

Summary

  • Clicking an Ingress or Deployment in canary view shows a modal with details for those components
  • Add placeholder visual for Pie charts without any data.

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 07bc437):

https://pluralsh-console--pr594-klink-canary-compone-ngwzmq7b.web.app

(expires Mon, 15 Jan 2024 20:44:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@dogmar dogmar added enhancement New feature or request frontend Changes related to the frontend labels Jan 8, 2024
@dogmar dogmar marked this pull request as ready for review January 9, 2024 02:05
@dogmar dogmar requested a review from a team January 9, 2024 02:05
@michaeljguarino michaeljguarino merged commit 7c4b660 into master Jan 9, 2024
11 of 12 checks passed
@michaeljguarino michaeljguarino deleted the klink/canary-components branch January 9, 2024 18:58
snikch pushed a commit to snikch/plural-console that referenced this pull request Apr 17, 2024
@dogmar @snikch
feat: Show details for Ingress/Deployments in canary view (pluralsh#594)
a74adb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend Changes related to the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dogmar @michaeljguarino