Improved canvas size getter to support high-dpi #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiakuan
commented
Dec 8, 2022
| .get_computed_style(&self.canvas) | ||
| .unwrap().unwrap(); | ||
| let width = style.get_property_value("width").unwrap().replace("px", ""); | ||
| let height = style.get_property_value("height").unwrap().replace("px", ""); |
There was a problem hiding this comment.
Here we can handle it better if the CSS uses a different unit, like pt or rem.
Also, error handlings can be improved.
Please let me know if there is an interest in merging the pull request, then I will improve it further. Otherwise, this code is good enough for my use case at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support high-dpi in HTML canvas, we need to scale the canvas size by devicePixelRatio first, and then use CSS style to configure the actual size, please see:
https://www.kirupa.com/canvas/canvas_high_dpi_retina.htm
The Canvas scaling part can be handled outside of this library, but in the
get_sizefunction, we need to get the size from the computed style, not the canvas, which may have been scaled.