feat: Add logger override option, use slog and capture driver as logs
#497
+113
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canstand
reviewed
Oct 21, 2024
| logger = option.Logger | ||
| } | ||
|
|
||
| if option.CaptureAllOutputWithLogger { |
There was a problem hiding this comment.
Hi @GuyGoldenberg, stderr of playwrightDriver is already redirected to options.Stderr in newPipTransport, and stdout only contains one-way communication protocol data. Is there a special reason to log the protocol output?options.stdout and options.stderr. It is recommended that the caller handle logging itself.
canstand
reviewed
Oct 21, 2024
| @@ -72,7 +74,7 @@ func (t *pipeTransport) Send(msg map[string]interface{}) error { | |||
| if os.Getenv("DEBUGP") != "" { | |||
| fmt.Fprint(os.Stdout, "\x1b[32mSEND>\x1b[0m\n") | |||
| if err := json.NewEncoder(os.Stdout).Encode(msg); err != nil { | |||
| logger.Printf("could not encode json: %v\n", err) | |||
| logger.Error("could not encode json", pwlogger.ErrAttr(err)) | |||
There was a problem hiding this comment.
Only for debugging when developing playwright-go. No errors are printed in the new PR. https://github.com/playwright-community/playwright-go/pull/500/files#diff-5982a4ca350449c8a5deba675bc4bc4bb0f1823c45e6c7ba0076cc6b159fef8fR73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 3 new changes:
logpackage tosloglogrbut this introduces a new dependency.slogsuch asslog-zerologslog-logrusSlogWriterwhich captures the output (stdoutandstderr) from the driver and writes them in the logger with added fields for context (stream and source)