Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction for running evolutions with Slick using compile-time DI #402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AnnikaSirapandjiNewWork
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 6, 2017

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #402   +/-   ##
======================================
  Coverage    7.71%   7.71%           
======================================
  Files          19      19           
  Lines         842     842           
  Branches        9       8    -1     
======================================
  Hits           65      65           
  Misses        777     777

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f74e06...cd421c5. Read the comment docs.

@@ -41,6 +41,9 @@ Note there is no need to add the Play `evolutions` component to your dependencie

> **Note**: You can see th

#### Running evolutions with Slick using compile-time DI
If you are using Slick, you will also need to mix in the `SlickEvolutionsComponents` trait in addition to the `EvolutionsComponents` trait to `ApplicationComponents`. Else evolutions will not recognize the Slick database configurations in the configuration files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be good to add a code sample here. You can see the recommended way of adding code samples here:

https://playframework.com/documentation/2.5.x/Documentation#Code-samples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, what do you think about changing the name to SlickDBComponents instead of SlickEvolutionsComponents? That would make things more straightforward since this basically replaces DBComponents. Then we can deprecate the whole trait instead of just that api method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmethvin +1.

Copy link
Member

@marcospereira marcospereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @annikasirapandji.

Just a small comment to add a code sample, but besides that, this looks good to me.

@marcospereira
Copy link
Member

Hi @annikasirapandji, could you please rebase against master branch?

Also, if you still have time, could you take a look at the comments made above? If not, please let me know and I can do it later. :-)

Moreover, thanks for contributing and sorry for the huge delay to move this forward.

@marcenuc
Copy link

How can I help to get this really helpful pull request merged?

Should I add a code snippet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants