Make test.sh script fail when any command fails
#613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mkurz
commented
Apr 29, 2024
mkurz
commented
- See comment [2.9.x] Update flyway-core to 9.22.1 #396 (comment)
mkurz
changed the title
test.sh script fail when any command fails
mkurz
commented
Apr 29, 2024
| @@ -166,7 +166,8 @@ jobs: | |||
| needs: changes | |||
| if: ${{ (github.event_name != 'pull_request' && !failure() && !cancelled()) || contains(fromJSON(needs.changes.outputs.samples), 'java-grpc')}} | |||
| with: | |||
| java: 17, 21 | |||
| # Can't test with Java 21+ currently because of https://github.com/lightbend/ssl-config/issues/367 | |||
| java: 17 | |||
There was a problem hiding this comment.
Because of lightbend/ssl-config#367 Exception: java.lang.IllegalArgumentException: GrpcClientSettings requires a server endpoint with ssl, but none provided
mkurz
force-pushed
the
make_test_script_fail
branch
from
306b016
to
7ccb825
Compare
mkurz
force-pushed
the
make_test_script_fail
branch
from
7ccb825
to
eca2f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.