Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests to format value classes #1041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added tests to format value classes #1041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions play-json/shared/src/test/scala/play/api/libs/json/JsonExtensionSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ object CustomApply {

case class Optional(props: Option[String])

case class UserId(id: Long) extends AnyVal

class JsonExtensionSpec extends AnyWordSpec with Matchers {
"JsonExtension" should {
"create a reads[User]" in {
Expand Down Expand Up @@ -749,5 +751,19 @@ class JsonExtensionSpec extends AnyWordSpec with Matchers {
formatter.reads(Json.obj("props" -> JsNull)).mustEqual(JsSuccess(Optional(None)))
formatter.reads(Json.obj("props" -> Some("foo"))).mustEqual(JsSuccess(Optional(Some("foo"))))
}
"format value classes" in {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"format value classes" in {
"format value classes" in {

implicit val userIdFmt: Format[UserId] = Json.format[UserId]
val userId = UserId(12345)
val serialized = Json.stringify(Json.toJson(userId))
serialized.mustEqual("""{"id":12345}""")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
serialized.mustEqual("""{"id":12345}""")
serialized.mustEqual("""{"id":12345}""")

Json.fromJson[UserId](Json.parse(serialized)).mustEqual(JsSuccess(userId))
}
"format value classes with value format" in {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"format value classes with value format" in {
"format value classes with value format" in {

implicit val userIdFmt: Format[UserId] = Json.valueFormat[UserId]
val userId = UserId(12345)
val serialized = Json.stringify(Json.toJson(userId))
serialized.mustEqual("""12345""")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
serialized.mustEqual("""12345""")
serialized.mustEqual("""12345""")

Json.fromJson[UserId](Json.parse(serialized)).mustEqual(JsSuccess(userId))
}
}
}
Loading