Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PekkoStream #572

Merged
merged 4 commits into from
Sep 9, 2023
Merged

Add PekkoStream #572

merged 4 commits into from
Sep 9, 2023

Conversation

kaplanbar
Copy link
Contributor

@kaplanbar kaplanbar commented Aug 18, 2023

Pull Request Checklist

Fixes

Adds PekkoStream to be used by Pekko users.

Purpose

Many applications are now migrating to Pekko due to Akka's license change. Some of them might be using AkkaStream from anorm, this supports them with their migration.

Background Context

I do not think there is a better approach, we have to duplicate the code.

References

#571

build.sbt Outdated Show resolved Hide resolved
pekko/src/main/scala/anorm/PekkoStream.scala Outdated Show resolved Hide resolved
pekko/src/main/scala/anorm/PekkoStream.scala Outdated Show resolved Hide resolved
pekko/src/test/resources/reference.conf Outdated Show resolved Hide resolved
pekko/src/test/scala-2.13+/PekkoCompat.scala Outdated Show resolved Hide resolved
pekko/src/test/scala-2.13-/PekkoCompat.scala Outdated Show resolved Hide resolved
@kaplanbar kaplanbar force-pushed the add-pekkostream branch 5 times, most recently from 704c268 to d02b633 Compare August 22, 2023 13:21
@kaplanbar
Copy link
Contributor Author

Thanks for your patient review. @cchantep I addressed remaining comments.

build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
pekko/src/main/scala/anorm/PekkoStream.scala Show resolved Hide resolved
@cchantep
Copy link
Member

need fixes

@kaplanbar kaplanbar force-pushed the add-pekkostream branch 3 times, most recently from c819d3e to 0f5e6d2 Compare August 24, 2023 14:44
@kaplanbar
Copy link
Contributor Author

need fixes

I am not able to find why it fails, do you have any hints?

sbt.librarymanagement.ResolveException: Error downloading org.playframework.anorm:anorm_2.12:2.7.1-05765f1c-SNAPSHOT
[error]   Not found
[error]   Not found
[error]   not found: /home/runner/.ivy2/localorg.playframework.anorm/anorm_2.12/2.7.1-05765f1c-SNAPSHOT/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/org/playframework/anorm/anorm_2.12/2.7.1-05765f1c-SNAPSHOT/anorm_2.12-2.7.1-05765f1c-SNAPSHOT.pom
[error]   not found: https://raw.github.com/cchantep/tatami/master/snapshots/org/playframework/anorm/anorm_2.12/2.7.1-05765f1c-SNAPSHOT/anorm_2.12-2.7.1-05765f1c-SNAPSHOT.pom
[error]   not found: https://oss.sonatype.org/content/repositories/snapshots/org/playframework/anorm/anorm_2.12/2.7.1-05765f1c-SNAPSHOT/anorm_2.12-2.7.1-05765f1c-SNAPSHOT.pom

@cchantep
Copy link
Member

Run sbt mimaReportBinaryIssues locally, probable missing an explicit mimaPreviousVersion

@kaplanbar
Copy link
Contributor Author

It passed when I run it locally:

sbt:anorm-parent> mimaReportBinaryIssues
[info] anorm-parent: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[info] anorm-pekko: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[info] anorm-postgres: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[info] anorm-enumeratum: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[success] Total time: 0 s, completed 25 Aug 2023, 12:36:43

🤔

@cchantep
Copy link
Member

+mimaReportBinaryIssues

@kaplanbar
Copy link
Contributor Author

+mimaReportBinaryIssues

I am not able to reproduce it locally neither with mimaReportBinaryIssues or +mimaReportBinaryIssues 😢

@cchantep cchantep force-pushed the add-pekkostream branch 3 times, most recently from 353eecb to d3b36bb Compare September 9, 2023 16:19
@cchantep cchantep merged commit ae46a2d into playframework:main Sep 9, 2023
21 checks passed
@gaeljw
Copy link
Member

gaeljw commented Nov 8, 2023

Hello, thanks for the work. Any idea when this will be released? I was upgrading to Play 3 and Pekko but stuck with this for the moment.

@bursauxa
Copy link
Contributor

Hello @cchantep any updates on this release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants