Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Latest Oclif #156

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update to Latest Oclif #156

wants to merge 1 commit into from

Conversation

KetanReddy
Copy link
Member

Closes #113

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Release Notes

Update to Oclif core 4.x

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Aug 5, 2024
@KetanReddy KetanReddy requested a review from a team August 5, 2024 23:41
@KetanReddy KetanReddy self-assigned this Aug 5, 2024
@KetanReddy
Copy link
Member Author

Because flipper requires an older version of oclif we can't upgrade the cli's version unless we break either one out of the tools repository

@adierkens
Copy link
Member

If we instead added the oclif dependency directly to the CLI package instead of the root, would that impact flipper?

@KetanReddy
Copy link
Member Author

KetanReddy commented Aug 6, 2024

Doesn't look like it would work out of the box. I think we would have to modify our bazel setup to have a different node modules location just for cli and link things between both that and the root one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Oclif Versions
2 participants