Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object null in deeply nested obejcts - devtools #158

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

mercillo
Copy link
Contributor

@mercillo mercillo commented Aug 7, 2024

dset had issues when encountering null in objects. This caused some issues with devtools not rendering the page correctly.

lukeed/dset#36

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Version

Published prerelease version: 0.7.1-next.2

Changelog

Release Notes

Fix Source Maps not Being Generated for DSL Content (#155)

Fix source maps not being generated for DSL content when compiled by the cli

Update Dependencies (#151)

  • Use Node 20
  • Use TypeScript 5.5

🐛 Bug Fix

Authors: 3

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 45.16129% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.06%. Comparing base (98f68e0) to head (9e8ab1c).
Report is 8 commits behind head on main.

Files Patch % Lines
.../plugins/desktop/profiler/src/WrapperComponent.tsx 0.00% 9 Missing ⚠️
...ols/plugins/desktop/basic/src/WrapperComponent.tsx 0.00% 6 Missing ⚠️
devtools/plugins/desktop/basic/src/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   73.05%   73.06%           
=======================================
  Files          87       87           
  Lines       12946    12945    -1     
  Branches     1216     1217    +1     
=======================================
  Hits         9458     9458           
+ Misses       3469     3468    -1     
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mercillo mercillo merged commit cf2296c into main Aug 14, 2024
7 of 8 checks passed
@mercillo mercillo deleted the fixObjectNullDevtools branch August 14, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants