Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SMTP defaults #4538

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Change SMTP defaults #4538

merged 7 commits into from
Sep 6, 2024

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Sep 6, 2024 •
edited
Loading

Changes

This PR changes default configs for the mailer and SMTP:

  • changes default sender email address to be based on BASE_URL
  • changes default SMTP client to Mua
  • disables problematic option in Erlang's TLS v1.3

Tests

  • Automated tests have been updated

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga marked this pull request as ready for review September 6, 2024 06:48
@ruslandoga
Copy link
Contributor Author

ruslandoga commented Sep 6, 2024 •
edited
Loading

CI is failing due to lau/tzdata#143

@ruslandoga ruslandoga changed the title Default SMTP config updates Change SMTP defaults Sep 6, 2024
@ruslandoga ruslandoga requested a review from a team September 6, 2024 07:07
@ruslandoga ruslandoga mentioned this pull request Sep 6, 2024
Merged
4 tasks
@zoldar zoldar merged commit 67d7c65 into master Sep 6, 2024
10 checks passed
@zoldar zoldar deleted the smtp-updates branch September 6, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoldar zoldar zoldar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruslandoga @zoldar