Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#8248 COUNTER R5 TSV reports #373

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#8248 COUNTER R5 TSV reports #373

wants to merge 9 commits into from

Conversation

bozana
Copy link
Contributor

@bozana bozana commented Jul 1, 2024

@bozana bozana mentioned this pull request Jul 1, 2024
Open
@bozana bozana force-pushed the 9666 branch 5 times, most recently from 559f143 to e547af2 Compare August 26, 2024 13:35
@bozana
Copy link
Contributor Author

bozana commented Aug 27, 2024 •
edited
Loading

Hi @jardakotesovec, I believe this is ready for your next review :-)
I think I have considered all suggestions from the first review round.
I have integrated your changes/commit for the customSubmit to work, and slightly adapted it in the next commit "adapt form".
And finally, why are the tests failing i.e. how should I proceed regarding them?
Thanks a lot!

jardakotesovec
jardakotesovec requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@jardakotesovec jardakotesovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major really.. but suggested couple of improvements.

Really appreciate willingness to familiarise with the composition api even its not completely necessary for this particular task. There is some getting used to - but it really gives lots of power for more complex UIs.

src/components/ListPanel/counter/CounterReportsEditModal.vue Outdated Show resolved Hide resolved
src/components/ListPanel/counter/CounterReportsEditModal.vue Outdated Show resolved Hide resolved
src/components/ListPanel/counter/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/components/ListPanel/counter/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/components/ListPanel/counter/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/components/ListPanel/counter/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/components/ListPanel/counter/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/components/ListPanel/counter/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/components/ListPanel/counter/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/pages/counter/CounterReportsPage.vue Outdated Show resolved Hide resolved
@bozana
Copy link
Contributor Author

bozana commented Oct 8, 2024

Hi @jardakotesovec, I believe I have considered all your comments -- only one question is left -- so it is ready for the next review round :-)
Thanks a lot!

@bozana
Copy link
Contributor Author

bozana commented Oct 9, 2024

Hi @jardakotesovec, I have considered all your comments. Could you please have another look?
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jardakotesovec jardakotesovec jardakotesovec requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bozana @jardakotesovec