-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COUNTER R5 form field customer_id is not provided correctly to the API endpoint #10350
Labels
Bug:1:Low
A bug that does not have a severe consequence or affects a small number of users.
Milestone
Comments
bozana
added
the
Bug:1:Low
A bug that does not have a severe consequence or affects a small number of users.
label
Aug 29, 2024
bozana
added a commit
to bozana/ui-library
that referenced
this issue
Aug 29, 2024
@jardakotesovec and @blesildaramirez, could you please review the PRs above? Thanks a lot! |
bozana
added a commit
to bozana/ojs
that referenced
this issue
Aug 29, 2024
bozana
added a commit
to bozana/omp
that referenced
this issue
Aug 29, 2024
bozana
added a commit
to bozana/ops
that referenced
this issue
Aug 29, 2024
This was referenced Aug 29, 2024
bozana
added a commit
to bozana/ui-library
that referenced
this issue
Aug 29, 2024
Hi @jardakotesovec and @blesildaramirez, could you please review (and approve) this PR -- it would be good if the bug fix would make it into the next release :-) |
bozana
added a commit
to bozana/ojs
that referenced
this issue
Sep 6, 2024
bozana
added a commit
to bozana/omp
that referenced
this issue
Sep 6, 2024
bozana
added a commit
to bozana/ops
that referenced
this issue
Sep 6, 2024
bozana
added a commit
to pkp/ui-library
that referenced
this issue
Sep 6, 2024
pkp/pkp-lib#10350 fix the check of the COUNTER R5 form field customer_id
bozana
added a commit
to pkp/ojs
that referenced
this issue
Sep 6, 2024
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
bozana
added a commit
to pkp/omp
that referenced
this issue
Sep 6, 2024
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
bozana
added a commit
to pkp/ops
that referenced
this issue
Sep 6, 2024
pkp/pkp-lib#10350 ui-library submodule update ##bozana/10350##
bozana
added a commit
to bozana/ui-library
that referenced
this issue
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The way the COUNTER R5 form field customer_id is checked here https://github.com/pkp/ui-library/blob/stable-3_4_0/src/components/Form/counter/CounterReportForm.vue#L39 is wrong:
When an institution is selected having an integer number > 0 as value the condition https://github.com/pkp/ui-library/blob/stable-3_4_0/src/components/Form/counter/CounterReportForm.vue#L44 is not passed.
S. also this forum post: https://forum.pkp.sfu.ca/t/counter-r5-report-generator-doesnt-work/90206.
Because we still work on porting the functionality to the main, this changes for main will be considered in this issue: #9666
PR:
pkp/ui-library#404
only submodule updates:
The text was updated successfully, but these errors were encountered: