pkp/pkp-lib#9895 app key and encryption service integration #4257
Conversation
config.TEMPLATE.inc.php
Outdated
| ; cipher = 'aes-256-cbc' | ||
|
|
||
| ; Define should the cookie at user's end need to be encrypted | ||
| ; Enabling/Disbaling will force all user to re-login |
dbscripts/xml/upgrade.xml
Outdated
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| <install version="3.5.0.0"> | |||
| <code function="checkPhpVersion" /> | |||
| <code function="addAppKey" /> | |||
There was a problem hiding this comment.
This should be added as a migration, not a <code ...> addition in the Upgrade class.
There was a problem hiding this comment.
@asmecher I understand it should part of upgrade and need to moved to upgrade class but I am confused about the migration part . I does not modify/update any DB tables but update the config.inc.php to add a unique app key if the app_key variable defined/set in the config.inc.php file . thats why it's added as <code ...> to run. or I am misunderstanding something ?
There was a problem hiding this comment.
The <code ...> pattern leads to accumulating cruft in the Upgrade class, so we're using Migration classes instead for new code. Migrations are good for whatever, not just database schema adaptations!
docs/release-notes/README-3.5.0
Outdated
| @@ -11,9 +11,15 @@ See config.TEMPLATE.inc.php for a description and examples of all supported | |||
| configuration parameters. | |||
|
|
|||
| New config.inc.php parameters added for general: | |||
| - session_cookie_enctyption_key (default value: ''), allow cookie encryption when set | |||
| - app_key (default value: ''), application specific key will used internally for encryption/decryption | |||
There was a problem hiding this comment.
Add a brief instruction for how to create this for those who are upgrading -- on second thought, since the upgrade script does this automatically, it would be better to note here that it'll be added on upgrade (since we normally don't do that).
touhidurabir
force-pushed
the
i9895_main
branch
2 times, most recently
from
2a3c298
to
d2926f6
Compare
for pkp/pkp-lib#9895