pkp/pkp-lib#9771 Move ORCID functionality into core application #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bozana
reviewed
Mar 28, 2024
| @@ -20,6 +20,8 @@ | |||
| @import "../../../../lib/pkp/styles/variables.less"; | |||
| @import "../../../../lib/pkp/styles/utils.less"; | |||
| @import "../../../../lib/pkp/styles/helpers.less"; | |||
| // General ORCID styles | |||
| @import '../../../../lib/pkp/styles/orcid.less'; | |||
There was a problem hiding this comment.
Maybe to not in the GitHub issue that other themes need to be adapted as well?
ewhanson
commented
Apr 9, 2024
ewhanson
commented
Apr 11, 2024
ewhanson
force-pushed
the
orcid
branch
3 times, most recently
from
054ec0c
to
ec2bf81
Compare
ewhanson
force-pushed
the
orcid
branch
4 times, most recently
from
216911f
to
536fa8d
Compare
bozana
reviewed
May 31, 2024
There was a problem hiding this comment.
Hi @ewhanson, great! Just 2-3 minor commnents -- you can decide if you would like to consider them.
Also, the functions in the class OrcidReview.php do not have descriptions -- similarly to the pkp-lib PR you can decide if you would like to add them.
ewhanson
force-pushed
the
orcid
branch
3 times, most recently
from
837552b
to
bd406ed
Compare
ewhanson
force-pushed
the
orcid
branch
2 times, most recently
from
cd88e6e
to
847e5ba
Compare
ewhanson
force-pushed
the
orcid
branch
3 times, most recently
from
33716fa
to
0aaea6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.