Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice 4: Use ModInstance type in mods updater #9192

Open
wants to merge 1 commit into
base: feature/devex-mod-instance-mods-screen
Choose a base branch
from
Open

Slice 4: Use ModInstance type in mods updater #9192

wants to merge 1 commit into from

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Sep 22, 2024 •
edited
Loading

What does this PR do?

Future Work

Continue gradual work toward eliminating mod components on the slice boundary:

  • Replace remaining occurrences of selectActivatedModComponents, selectGetModComponentsForMod, selectModHasAnyActivatedModComponents, etc.
  • Replace component slice actions taking mod components with actions taking mod instances

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller changed the base branch from main to feature/devex-mod-instance-mods-screen September 22, 2024 23:53
twschiller
twschiller commented Sep 22, 2024
View reviewed changes
src/background/modUpdater.test.ts
@@ -143,42 +143,6 @@ describe("getActivatedMarketplaceModVersions function", () => {
},
]);
});

it("reports error if multiple mod component versions activated for same mod", async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't happen anymore - ModInstance only has a single version

twschiller
twschiller commented Sep 22, 2024
View reviewed changes
src/background/utils/deactivateMod.test.ts
);

expect(nextModComponentState.activatedModComponents).toHaveLength(1);
});

it("should do nothing if mod id does not have any activated mod components", async () => {
Copy link
Contributor Author

@twschiller twschiller Sep 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having it do nothing, the caller is now responsible for skipping. (The caller must produce a ModInstance value)

@twschiller twschiller added developer experience do not merge Merging of this PR is blocked by another one 30% time labels Sep 22, 2024
@twschiller twschiller self-assigned this Sep 22, 2024
@github-actions GitHub Actions
Copy link

Playwright test results

passed  125 passed
flaky  5 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  134 tests across 44 suites
duration  13 minutes, 56 seconds
commit  eefe60b
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod
chrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller marked this pull request as draft September 23, 2024 00:24
@twschiller twschiller mentioned this pull request Sep 23, 2024
Open
@twschiller
Use mod instance in marketplace mod updater
56f447b 
Remove test debugging statement
@twschiller twschiller force-pushed the feature/devex-mod-instance-updater branch from eefe60b to 56f447b Compare September 23, 2024 02:23
@twschiller twschiller marked this pull request as ready for review September 23, 2024 02:23
@twschiller twschiller changed the title Use ModInstance type in Mods Update (4/3) Use ModInstance type in mods updater (4/3) Sep 23, 2024
@twschiller twschiller changed the title Use ModInstance type in mods updater (4/3) Slice 4: Use ModInstance type in mods updater Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamlangford grahamlangford Awaiting requested review from grahamlangford

Assignees

@twschiller twschiller

Labels
30% time developer experience do not merge Merging of this PR is blocked by another one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twschiller