Skip to content

Commit

Permalink
MINOR: [Python][CI] Avoid unconditional use of precompiled headers
Browse files Browse the repository at this point in the history
The precompiled headers generated during the PyArrow build phase seem to take a lot of disk space (more than 2 GB).

Avoiding their unconditional generation should make disk space issues on CI less likely.
  • Loading branch information
pitrou committed Oct 2, 2024
1 parent 15cc84d commit 7233d1a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ endif()
add_library(arrow_python SHARED ${PYARROW_CPP_SRCS})
target_include_directories(arrow_python PUBLIC ${PYARROW_CPP_ROOT_DIR}
${CMAKE_CURRENT_BINARY_DIR}/pyarrow/src)
if(NOT CMAKE_VERSION VERSION_LESS 3.16)
if(ARROW_USE_PRECOMPILED_HEADERS AND NOT CMAKE_VERSION VERSION_LESS 3.16)
target_precompile_headers(arrow_python PUBLIC
"$<$<COMPILE_LANGUAGE:CXX>:arrow/python/pch.h>")
endif()
Expand Down
2 changes: 2 additions & 0 deletions python/pyarrow/src/arrow/python/udf.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
// under the License.

#include "arrow/python/udf.h"

#include "arrow/array/array_nested.h"
#include "arrow/array/builder_base.h"
#include "arrow/buffer_builder.h"
#include "arrow/compute/api_aggregate.h"
Expand Down

0 comments on commit 7233d1a

Please sign in to comment.