Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanly close agent goroutines #706

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Jul 1, 2024

This ensures no goroutines are running when an ICE agent closes. I'd also like to backport this into v2 so that webrtc/v3 can get it.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.07%. Comparing base (2a9fdb5) to head (72c7732).

Files Patch % Lines
agent_handlers.go 67.85% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
- Coverage   79.19%   79.07%   -0.12%     
==========================================
  Files          41       41              
  Lines        3739     3771      +32     
==========================================
+ Hits         2961     2982      +21     
- Misses        547      557      +10     
- Partials      231      232       +1     
Flag Coverage Δ
go 79.07% <75.00%> (-0.12%) ⬇️
wasm 22.23% <30.55%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidzhao davidzhao requested a review from paulwe July 1, 2024 22:13
@davidzhao
Copy link
Member

@paulwe tagging you on this as it closely matches with your initial comments about not leaving behind rogue goroutines

@edaniels edaniels merged commit d8341e7 into pion:master Jul 2, 2024
14 checks passed
@edaniels edaniels deleted the clean_close_agent branch July 2, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants